Closed Bug 1047757 Opened 6 years ago Closed 6 years ago
Service is leaked
We store BluetoothService in a StaticRefPtr which is never cleared, so we leak. The obvious thing to do here is use ClearOnShutdown on the StaticRefPtr.
Target Milestone: --- → 2.1 S2 (15aug)
As Kyle mentioned, we should call ClearOnShutdown(sBluetoothService) for nulling sBluetoothService on shutdown. Patch Summary: * Call ClearOnShutdown(sBluetoothService) after creating the instance. * Use sBluetoothService directly in BluetoothService::Get() Hi Shawn, Could you help on reviewing this patch? Thanks.
Attachment #8468221 - Flags: review?(shuang)
Attachment #8468221 - Flags: review?(shuang) → review+
Whiteboard: [p=1] → [p=1][c=memory u= p= s=]
Thanks for your time, Shawn.
Attachment #8468221 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
6 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.