1047757 - BluetoothService is leaked

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect, P2)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We store BluetoothService in a StaticRefPtr which is never cleared, so we leak.  The obvious thing to do here is use ClearOnShutdown on the StaticRefPtr.

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1047757: Call ClearOnShutdown(sBluetoothService) to fix memory leak.

As Kyle mentioned, we should call ClearOnShutdown(sBluetoothService) for nulling sBluetoothService on shutdown.
Patch Summary:
* Call ClearOnShutdown(sBluetoothService) after creating the instance.
* Use sBluetoothService directly in BluetoothService::Get()

Hi Shawn,

Could you help on reviewing this patch? Thanks.

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1047757: Call ClearOnShutdown(sBluetoothService) to fix memory leak. r=shuang

Thanks for your time, Shawn.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Try:
https://tbpl.mozilla.org/?tree=Try&rev=bba1449d3779

Comment 4

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/8542bcd9ab6d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8542bcd9ab6d

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Thanks Jocelyn!