Closed Bug 1047759 Opened 7 years ago Closed 7 years ago

FMRadioService is leaked

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: khuey, Assigned: pzhang)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

We store the FMRadioService in a StaticRefPtr that is never cleared, so we leak.  The obvious thing to do here is use ClearOnShutdown on the StaticRefPtr.  But I wonder if we really need the StaticRefPtr at all.  Can we rely on somebody else (maybe the XPCOM service manager) holding us alive?
Attached patch patchSplinter Review
Attachment #8466885 - Flags: review?(khuey)
Attachment #8466885 - Flags: review?(khuey) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/003e3f31ea6b
Assignee: nobody → pzhang
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.