1047824 - MP4Reader needs to call PlatformDecoderModule::Shutdown()

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

D'oh! MP4Reader was supposed to call PlatformDecoderModule::Shutdown(), but actually doesn't. It should...

It should really also call PlatformDecoderModule::Shutdown() on the decode task queue instead of on the main thread (like the comments in PDM.h say), since every other call into the PDM is on the decode task queue too.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

* Make MP4Reader::Shutdown() override MediaDecoderReader::Shutdown(), so it's called on the decode task queue (instead (probably) the main thread in MP4Reader's dtor). This means MP4Reader::Shutdown()'s calls to MediaDataDecoder::Shutdown() and the shutdown of the decode task queues happen on the decode task queue instead of the main thread.
* Add PDM::Shutdown() call to MP4Reader::Shutdown(), and adjust comments in PDM.h to match reality.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 2: Make Apple PDM Shutdown work OMT

* Make AppleDecoderModule::Shutdown() defer Unlink to the main thread; so it works when called from the decode task queue with patch 1 applied.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8466642 [details] [diff] [review]
Patch 2: Make Apple PDM Shutdown work OMT

Review of attachment 8466642 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with syntax error addressed.

::: content/media/fmp4/apple/AppleDecoderModule.cpp
@@ +69,2 @@
>  nsresult
>  AppleDecoderModule::Shutdown()

Missing open brace here.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e33eb233cd50
https://hg.mozilla.org/integration/mozilla-inbound/rev/b32edb4b9952

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e33eb233cd50
https://hg.mozilla.org/mozilla-central/rev/b32edb4b9952