Notification bar: close icon should be inverted on black notification bars

VERIFIED FIXED in mozilla38

Status

()

Toolkit
Themes
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Sören Hentzschel, Assigned: MattN)

Tracking

({access, polish})

33 Branch
mozilla38
All
Mac OS X
access, polish
Points:
1
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify +

Firefox Tracking Flags

(firefox33 affected, firefox34 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8466760 [details]
screenshot

Bug 693808 introduced a notification bar after entering numbers or single words in the location bar and then pressing enter. On OS X the close button is black on a black background and difficult to recognize.
status-firefox33: --- → affected
status-firefox34: --- → affected
Version: Trunk → 33 Branch

Comment 1

3 years ago
Marco, can you add this to the upcoming iteration?
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 34.2
Points: --- → 1
QA Whiteboard: [qa+]
Component: Theme → Themes
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
Keywords: access, polish
Product: Firefox → Toolkit

Updated

3 years ago
Summary: Notification bar: Black icon on black background → Notification bar: close icon should be inverted on black notification bars
Forwarding 'needinfo' to Gavin for consideration of this bug in upcoming Iteration 34.2

(In reply to :Gijs Kruitbosch (Bugmail catchup, needinfo if urgent) from comment #1)
> Marco, can you add this to the upcoming iteration?
Iteration: 34.2 → ---
Flags: needinfo?(mmucci) → needinfo?(gavin.sharp)
Isn't this an existing notification bar bug?
Flags: needinfo?(gavin.sharp)

Comment 4

3 years ago
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #3)
> Isn't this an existing notification bar bug?

Maybe. I've not checked if it wasn't regressed by the work we did to unify the close buttons in the UI. In any case, it should be easy to fix and this notification bar makes it more visible.

Alternatively, we could wait for the redesign of the notification bars, if that is forthcoming...
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #3)
> Isn't this an existing notification bar bug?

Yes, it is. In this case the close button is also redundant with the "No thanks" (sic!) button, as I understand it.
No longer blocks: 693808

Comment 6

3 years ago
Created attachment 8468449 [details] [diff] [review]
imported patch -notification-icon

This is the somewhat obvious choice for fixing this, but it doesn't work. The styling in global/skin/ overrides this one. I don't know why, except that this is a XBL-included stylesheet and the other style isn't? Maybe? In any case, if there is little motivation to get this fixed (particularly if we're going to be landing this redesign sooner rather than later) then I'm not sure it's worth spending more time on this.

Updated

3 years ago
Assignee: gijskruitbosch+bugs → nobody
Status: ASSIGNED → NEW
Created attachment 8557753 [details]
MozReview Request: bz://1047977/MattN

/r/3247 - Bug 1047977 - Invert the notification bar close icon with @type=info to provide contrast.

Pull down this commit:

hg pull review -r 31f22d49053f68e7cf641d4a699d99e4184ec866
Attachment #8557753 - Flags: review?(gijskruitbosch+bugs)
This annoys me multiple times per week when I create a temporary profile and see the data choices notification. I can't figure out why Gijs' patch doesn't work but !important seems to work. Since this is fairly localized and the style will possibly be replaced by the new notification bar styling I think !important is okay for the short term to improve the first run primary UI experience.

Updated

3 years ago
Attachment #8557753 - Flags: review?(gijskruitbosch+bugs) → review+

Updated

3 years ago
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 38.2 - 9 Feb
QA Whiteboard: [qa+]
Flags: qe-verify+
https://hg.mozilla.org/integration/fx-team/rev/d10615f7421b
Flags: in-testsuite-
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d10615f7421b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla38
QA Contact: andrei.vaida
This is now indeed fixed for Mac OS X 10.9.5 using:
- latest Nightly, build ID: 20150308030227.
- latest Aurora, build ID: 20150308004051.

This issue is only fixed for Mac OS X, I've filled bug 1141061 for Windows and Linux platforms.
Status: RESOLVED → VERIFIED
QA Contact: andrei.vaida → cornel.ionce
Comment on attachment 8557753 [details]
MozReview Request: bz://1047977/MattN
Attachment #8557753 - Attachment is obsolete: true
Attachment #8618255 - Flags: review+
Created attachment 8618255 [details]
MozReview Request: Bug 1047977 - Invert the notification bar close icon with @type=info to provide contrast.
You need to log in before you can comment on or make changes to this bug.