Closed Bug 1047977 Opened 5 years ago Closed 5 years ago
Notification bar: close icon should be inverted on black notification bars
239.23 KB, image/png
1.20 KB, patch
|Details | Diff | Splinter Review|
MozReview Request: Bug 1047977 - Invert the notification bar close icon with @type=info to provide contrast.
39 bytes, text/x-review-board-request
Bug 693808 introduced a notification bar after entering numbers or single words in the location bar and then pressing enter. On OS X the close button is black on a black background and difficult to recognize.
Marco, can you add this to the upcoming iteration?
Summary: Notification bar: Black icon on black background → Notification bar: close icon should be inverted on black notification bars
Forwarding 'needinfo' to Gavin for consideration of this bug in upcoming Iteration 34.2 (In reply to :Gijs Kruitbosch (Bugmail catchup, needinfo if urgent) from comment #1) > Marco, can you add this to the upcoming iteration?
Iteration: 34.2 → ---
Flags: needinfo?(mmucci) → needinfo?(gavin.sharp)
Isn't this an existing notification bar bug?
(In reply to :Gavin Sharp [email: email@example.com] from comment #3) > Isn't this an existing notification bar bug? Maybe. I've not checked if it wasn't regressed by the work we did to unify the close buttons in the UI. In any case, it should be easy to fix and this notification bar makes it more visible. Alternatively, we could wait for the redesign of the notification bars, if that is forthcoming...
(In reply to :Gavin Sharp [email: firstname.lastname@example.org] from comment #3) > Isn't this an existing notification bar bug? Yes, it is. In this case the close button is also redundant with the "No thanks" (sic!) button, as I understand it.
No longer blocks: 693808
This is the somewhat obvious choice for fixing this, but it doesn't work. The styling in global/skin/ overrides this one. I don't know why, except that this is a XBL-included stylesheet and the other style isn't? Maybe? In any case, if there is little motivation to get this fixed (particularly if we're going to be landing this redesign sooner rather than later) then I'm not sure it's worth spending more time on this.
/r/3247 - Bug 1047977 - Invert the notification bar close icon with @type=info to provide contrast. Pull down this commit: hg pull review -r 31f22d49053f68e7cf641d4a699d99e4184ec866
Attachment #8557753 - Flags: review?(gijskruitbosch+bugs)
This annoys me multiple times per week when I create a temporary profile and see the data choices notification. I can't figure out why Gijs' patch doesn't work but !important seems to work. Since this is fairly localized and the style will possibly be replaced by the new notification bar styling I think !important is okay for the short term to improve the first run primary UI experience.
Attachment #8557753 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 38.2 - 9 Feb
QA Whiteboard: [qa+]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
This is now indeed fixed for Mac OS X 10.9.5 using: - latest Nightly, build ID: 20150308030227. - latest Aurora, build ID: 20150308004051. This issue is only fixed for Mac OS X, I've filled bug 1141061 for Windows and Linux platforms.
Status: RESOLVED → VERIFIED
QA Contact: andrei.vaida → cornel.ionce
You need to log in before you can comment on or make changes to this bug.