1048017 - Pref on screensharing by default now that whitelisting has landed and tests are running

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Screensharing is now protected from use by random web content by a pref whitelists (bug 1037424).  Since tests have also landed in bug 1039666, I'm flipping the feature on by default (users will still need to edit the whitelist in about:config to use it with a specific site); this means that the requirement will be more strict (site-specific) than the previous protection just by the enable pref (turned on for all sites if you flipped it).

Landing under rs=module owner

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: pref on WebRTC screensharing - whitelist blocks access by default rs=jesup

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8466789 [details] [diff] [review]
pref on WebRTC screensharing - whitelist blocks access by default rs=jesup

rs=moduleowner

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba49cca9883e

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8466789 [details] [diff] [review]
pref on WebRTC screensharing - whitelist blocks access by default rs=jesup

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Users will need to edit two prefs in about:config to enable screensharing.  (Note: I believe we'll be adding a default string to the whitelist in 33; if so we'd want this to be enabled.)

[Describe test coverage new/current, TBPL]: Windows/screen sharing tests have landed; this should be uplifted with them.  The actual uplift would be gated on uplifting them.

[Risks and why]: none - whitelist blocks usage regardless of this value

[String/UUID change made/needed]: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba49cca9883e

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I think this should be part of the 33 release notes, right?

Comment 7

[Florian Quèze [:florian]]

(In reply to Randell Jesup [:jesup] from comment #4)

> [User impact if declined]: Users will need to edit two prefs in about:config
> to enable screensharing.  (Note: I believe we'll be adding a default string
> to the whitelist in 33; if so we'd want this to be enabled.)

Note: bug 1037424 hasn't reached aurora yet, and I think it should before we pref on there.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Florian Quèze [:florian] [:flo] from comment #7)
> (In reply to Randell Jesup [:jesup] from comment #4)
> 
> > [User impact if declined]: Users will need to edit two prefs in about:config
> > to enable screensharing.  (Note: I believe we'll be adding a default string
> > to the whitelist in 33; if so we'd want this to be enabled.)
> 
> Note: bug 1037424 hasn't reached aurora yet, and I think it should before we
> pref on there.

Yes - I've marked that one for uplift as well.  Thanks

Comment 9

[Paul Silaghi, QA [:pauly]]

(In reply to Randell Jesup [:jesup] from comment #4)
> [User impact if declined]: Users will need to edit two prefs in about:config
> to enable screensharing. 
media.getusermedia.screensharing.enabled and what's the second one?

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

See bug 1037424 - media.getusermedia.screensharing.allowed_domains

for webrtc-landing, it would be "mozilla.github.io"

Comment 11

[Paul Silaghi, QA [:pauly]]

So, this bug only sets media.getusermedia.screensharing.enabled=TRUE.
Confirmed in 34.0a1 (2014-08-05), Win 7 x64.

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/793c7a968030

Comment 13

[Florin Mezei, QA (:FlorinMezei)]

Verified in Firefox 33 Beta 1 (BuildID=20140902214533) on Win 7 x64 and media.getusermedia.screensharing.enabled is set to true by default.