Closed Bug 1048017 Opened 5 years ago Closed 5 years ago

Pref on screensharing by default now that whitelisting has landed and tests are running

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla34
Tracking Status
firefox33 --- verified
firefox34 --- verified

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file)

Screensharing is now protected from use by random web content by a pref whitelists (bug 1037424).  Since tests have also landed in bug 1039666, I'm flipping the feature on by default (users will still need to edit the whitelist in about:config to use it with a specific site); this means that the requirement will be more strict (site-specific) than the previous protection just by the enable pref (turned on for all sites if you flipped it).

Landing under rs=module owner
Comment on attachment 8466789 [details] [diff] [review]
pref on WebRTC screensharing - whitelist blocks access by default rs=jesup

rs=moduleowner
Attachment #8466789 - Flags: review+
Assignee: nobody → rjesup
Comment on attachment 8466789 [details] [diff] [review]
pref on WebRTC screensharing - whitelist blocks access by default rs=jesup

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Users will need to edit two prefs in about:config to enable screensharing.  (Note: I believe we'll be adding a default string to the whitelist in 33; if so we'd want this to be enabled.)

[Describe test coverage new/current, TBPL]: Windows/screen sharing tests have landed; this should be uplifted with them.  The actual uplift would be gated on uplifting them.

[Risks and why]: none - whitelist blocks usage regardless of this value

[String/UUID change made/needed]: none
Attachment #8466789 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/ba49cca9883e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attachment #8466789 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I think this should be part of the 33 release notes, right?
Flags: needinfo?(rjesup)
(In reply to Randell Jesup [:jesup] from comment #4)

> [User impact if declined]: Users will need to edit two prefs in about:config
> to enable screensharing.  (Note: I believe we'll be adding a default string
> to the whitelist in 33; if so we'd want this to be enabled.)

Note: bug 1037424 hasn't reached aurora yet, and I think it should before we pref on there.
(In reply to Florian Quèze [:florian] [:flo] from comment #7)
> (In reply to Randell Jesup [:jesup] from comment #4)
> 
> > [User impact if declined]: Users will need to edit two prefs in about:config
> > to enable screensharing.  (Note: I believe we'll be adding a default string
> > to the whitelist in 33; if so we'd want this to be enabled.)
> 
> Note: bug 1037424 hasn't reached aurora yet, and I think it should before we
> pref on there.

Yes - I've marked that one for uplift as well.  Thanks
Flags: needinfo?(rjesup)
(In reply to Randell Jesup [:jesup] from comment #4)
> [User impact if declined]: Users will need to edit two prefs in about:config
> to enable screensharing. 
media.getusermedia.screensharing.enabled and what's the second one?
Flags: needinfo?(rjesup)
See bug 1037424 - media.getusermedia.screensharing.allowed_domains

for webrtc-landing, it would be "mozilla.github.io"
Flags: needinfo?(rjesup)
So, this bug only sets media.getusermedia.screensharing.enabled=TRUE.
Confirmed in 34.0a1 (2014-08-05), Win 7 x64.
Status: RESOLVED → VERIFIED
Keywords: qawanted, verifyme
Verified in Firefox 33 Beta 1 (BuildID=20140902214533) on Win 7 x64 and media.getusermedia.screensharing.enabled is set to true by default.
You need to log in before you can comment on or make changes to this bug.