convert bug 651803 dupes to INVALID bugs in "Invalid Bugs" product

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Infrastructure
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Dave Garrett, Assigned: fubar)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
https://bugzilla.mozilla.org/describecomponents.cgi?product=Invalid%20Bugs

Bug 651803 was the standard place to dupe all spam/test bugs to for a few years. There is a new "Invalid Bugs" product in BMO to dump spam/test bugs into so they don't clutter up searches for actual bugs in the products/components they were filed to. It's nice to see this finally implemented; it's a much better way to deal with this problem. All 591 of bug 651803's dupes can easily be marked INVALID and changed to go into this new product (w/ reset assignee & QA fields) with a single mass change. However, that would send out thousands of useless notifications that nobody cares about. Can someone make this mass change without notification emails?

Updated

4 years ago
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Reporter)

Comment 1

4 years ago
To be clear, the list of changes for each bug to be made in one mass change:
* Change product to "Invalid Bugs" (& component to its "General")
* Change status to "RESOLVED INVALID" instead of duplicate
* Reset assignee
* Reset QA contact
Created attachment 8468030 [details]
move_dupes_to_invalid.pl
Attachment #8468030 - Flags: review?(glob)
Comment on attachment 8468030 [details]
move_dupes_to_invalid.pl

please attach patches, not files.


you need to trigger a recalculation of the user profile data for everyone involved in those bugs.

>my $doit = 0;
>GetOptions("doit" => \$doit);

i don't think "doit" makes much sense for these scripts -- it's too easy to forget to ask IT to pass that parameter, and there's no clear output that nothing actually happened.

change to a confirmation prompt with ^C to cancel.

>    if ($bug_count == 0) {
>        warn "There are no duplicate bugs to move for bug $dupe_of_bug.\n";
>        exit 1;
>    }

use "die" instead of warn and exit(1).
Attachment #8468030 - Flags: review?(glob) → review-
Created attachment 8468525 [details] [diff] [review]
1048053_1.patch
Attachment #8468030 - Attachment is obsolete: true
Attachment #8468525 - Flags: review?(glob)
Comment on attachment 8468525 [details] [diff] [review]
1048053_1.patch

Review of attachment 8468525 [details] [diff] [review]:
-----------------------------------------------------------------

this mostly looks good, but the user-profile recounting needs to be tested.

::: contrib/reorg-tools/move_dupes_to_invalid.pl
@@ +78,5 @@
> +        $count++;
> +        indicate_progress({ current => $count, total => $bug_count, every => 1 });
> +    }
> +
> +    Bugzilla::Hook::process('reorg_move_bugs', { bug_ids => [ $dupe_of_bug, @$duped_bugs ] });

you need to load the extensions in order for this hook to work.

use Bugzilla;
BEGIN { Bugzilla->extensions() }
Attachment #8468525 - Flags: review?(glob) → review-
Created attachment 8469311 [details] [diff] [review]
1048053_2.patch
Attachment #8468525 - Attachment is obsolete: true
Attachment #8469311 - Flags: review?(glob)
Comment on attachment 8469311 [details] [diff] [review]
1048053_2.patch

Review of attachment 8469311 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #8469311 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   bc450dc..d4eb36b  master -> master
To satisfy this request I need an admin to run a couple of scripts on the BMO system.

NOTE: Please execute on the staging server first and report back the output just as a precaution.

1. cd to the web root for BMO (cgi files for Bugzilla)
2. # perl contrib/reorg-tools/syncmsandversions.pl Firefox ""Invalid Bugs"
3. # perl contrib/reorg-tools/move_dupes_to_invalid.pl 651803

Thanks
dkl
Assignee: dkl → nobody
Status: ASSIGNED → NEW
Component: Administration → Infrastructure
QA Contact: mcote
(Assignee)

Comment 10

4 years ago
On staging... 
bugzillaadm.private.scl3# time perl contrib/reorg-tools/syncmsandversions.pl Firefox "Invalid Bugs"
Can't find product ID for 'Invalid Bugs'.

real	0m0.481s
user	0m0.414s
sys	0m0.044s
Assignee: nobody → klibby
i've created the product "Invalid Bugs" on stage; please try again.
(Assignee)

Comment 12

4 years ago
On staging...

bugzillaadm.private.scl3# time perl contrib/reorg-tools/syncmsandversions.pl Firefox "Invalid Bugs"

real	0m0.867s
user	0m0.726s
sys	0m0.095s

bugzillaadm.private.scl3# time perl contrib/reorg-tools/move_dupes_to_invalid.pl 651803
Moving 588 duplicate bugs from bug 651803 to the 'Invalid Bugs' product.

Press <Ctrl-C> to stop or <Enter> to continue...

............................................................60/588 (10%)
............................................................120/588 (20%)
............................................................180/588 (30%)
............................................................240/588 (40%)
............................................................300/588 (51%)
............................................................360/588 (61%)
............................................................420/588 (71%)
............................................................480/588 (81%)
............................................................540/588 (91%)
................................................588/588 (100%)
Touching user profile data for 589 bugs.
Updated 2047 users.

real	5m2.877s
user	0m39.742s
sys	0m10.303s
(In reply to Kendall Libby [:fubar] from comment #12)
> On staging...
> 
> bugzillaadm.private.scl3# time perl contrib/reorg-tools/syncmsandversions.pl
> Firefox "Invalid Bugs"
> 
> real	0m0.867s
> user	0m0.726s
> sys	0m0.095s
> 
> bugzillaadm.private.scl3# time perl
> contrib/reorg-tools/move_dupes_to_invalid.pl 651803
> Moving 588 duplicate bugs from bug 651803 to the 'Invalid Bugs' product.
> 
> Press <Ctrl-C> to stop or <Enter> to continue...
> 
> ............................................................60/588 (10%)
> ............................................................120/588 (20%)
> ............................................................180/588 (30%)
> ............................................................240/588 (40%)
> ............................................................300/588 (51%)
> ............................................................360/588 (61%)
> ............................................................420/588 (71%)
> ............................................................480/588 (81%)
> ............................................................540/588 (91%)
> ................................................588/588 (100%)
> Touching user profile data for 589 bugs.
> Updated 2047 users.
> 
> real	5m2.877s
> user	0m39.742s
> sys	0m10.303s

591 currently on production so that looks sane to me. When can we run this on prod?

dkl

Updated

4 years ago
Flags: needinfo?(klibby)
(Assignee)

Comment 14

4 years ago
Done.

bugzillaadm.private.scl3# time perl contrib/reorg-tools/move_dupes_to_invalid.pl 651803
Moving 591 duplicate bugs from bug 651803 to the 'Invalid Bugs' product.

Press <Ctrl-C> to stop or <Enter> to continue...

............................................................60/591 (10%)
............................................................120/591 (20%)
............................................................180/591 (30%)
............................................................240/591 (40%)
............................................................300/591 (50%)
............................................................360/591 (60%)
............................................................420/591 (71%)
............................................................480/591 (81%)
............................................................540/591 (91%)
...................................................591/591 (100%)
Touching user profile data for 592 bugs.
Updated 2071 users.

real	9m39.324s
user	0m44.078s
sys	0m22.065s
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(klibby)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.