1048173 - If Firefox was compiled with FFmpeg support and FFmpeg isn't installed: it will crash

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

if firefox has been compiled with --enable-ffmpeg, media.fragmented-mp4.ffmpeg.enabled is set to true in about:config

Attempting to play a video will cause a crash.

Comment 1

[Jean-Yves Avenard [:jya]]

the issue isn't located to macos, same will happen on linux

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Make sure we can link against FFmpeg libraries before attempting to create a decoder

Bug 1048173: Ensure FFmpeg libraries can be linked against before creating decoder

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8466975 [details] [diff] [review]
Make sure we can link against FFmpeg libraries before attempting to create a decoder

Wow, that's bad. Nice catch.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Make sure we can link against FFmpeg libraries before attempting to create a decoder

Bug 1048173: Ensure FFmpeg libraries can be linked against before creating decoder

Comment 5

[Jean-Yves Avenard [:jya]]

Different approach. This one allows for future/possible changes in CreateDecoderModule() that does create the decoder, but for some reason is invalid...

Comment 6

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=acf2a451f0d8

Comment 7

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=d75ff0f4bd6a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5d1b7362d9b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5d1b7362d9b