If Firefox was compiled with FFmpeg support and FFmpeg isn't installed: it will crash

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jya, Assigned: jya, Mentored)

Tracking

Trunk
mozilla34
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
if firefox has been compiled with --enable-ffmpeg, media.fragmented-mp4.ffmpeg.enabled is set to true in about:config

Attempting to play a video will cause a crash.
(Assignee)

Comment 1

4 years ago
the issue isn't located to macos, same will happen on linux
(Assignee)

Comment 2

4 years ago
Created attachment 8466975 [details] [diff] [review]
Make sure we can link against FFmpeg libraries before attempting to create a decoder

Bug 1048173: Ensure FFmpeg libraries can be linked against before creating decoder
Attachment #8466975 - Flags: review?(edwin)
(Assignee)

Updated

4 years ago
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Comment on attachment 8466975 [details] [diff] [review]
Make sure we can link against FFmpeg libraries before attempting to create a decoder

Wow, that's bad. Nice catch.
Attachment #8466975 - Flags: review?(edwin) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 8467563 [details] [diff] [review]
Make sure we can link against FFmpeg libraries before attempting to create a decoder

Bug 1048173: Ensure FFmpeg libraries can be linked against before creating decoder
Attachment #8467563 - Flags: review?(edwin)
(Assignee)

Updated

4 years ago
Attachment #8466975 - Attachment is obsolete: true
(Assignee)

Comment 5

4 years ago
Different approach. This one allows for future/possible changes in CreateDecoderModule() that does create the decoder, but for some reason is invalid...
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b5d1b7362d9b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.