Closed Bug 1048173 Opened 7 years ago Closed 7 years ago

If Firefox was compiled with FFmpeg support and FFmpeg isn't installed: it will crash

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jya, Assigned: jya, Mentored)

Details

Attachments

(1 file, 1 obsolete file)

if firefox has been compiled with --enable-ffmpeg, media.fragmented-mp4.ffmpeg.enabled is set to true in about:config

Attempting to play a video will cause a crash.
the issue isn't located to macos, same will happen on linux
Bug 1048173: Ensure FFmpeg libraries can be linked against before creating decoder
Attachment #8466975 - Flags: review?(edwin)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Comment on attachment 8466975 [details] [diff] [review]
Make sure we can link against FFmpeg libraries before attempting to create a decoder

Wow, that's bad. Nice catch.
Attachment #8466975 - Flags: review?(edwin) → review+
Bug 1048173: Ensure FFmpeg libraries can be linked against before creating decoder
Attachment #8467563 - Flags: review?(edwin)
Attachment #8466975 - Attachment is obsolete: true
Different approach. This one allows for future/possible changes in CreateDecoderModule() that does create the decoder, but for some reason is invalid...
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b5d1b7362d9b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.