1048373 - [settings] can't join hidden network, have to join it twice to see a connection attempt, also twice in list (1x Open, 1x WPA-PSK)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox OS 2.1.0.0-prerelease 20140803221934 on Geeksphone Keon

When opening the settings and trying to join a hidden wifi network which doesn't broadcast its ssid, I have to join the network twice to connect.

Steps to reproduce:
1. Open Settings.
2. Open Wi-Fi.
3. Open "Manage networks"
4. Select "Join hidden network"
5. Enter SSID and password (I use WPA-PSK).
Actual result:
Wifi not joined after entering credentials.
Wifi network shown as "Open" in list of hidden networks.
6. Go back to the "Wi-Fi" screen. If the SSID you entered isn't listed here, either kill the Settings app or repeat 3.-5.
7. Tap on the SSID you already entered in the "Wi-Fi" panel.
8. Enter the password again.
9. Eventually, try to join the network.
Actual result:
See connection attempt in notification bar, calling a page in browser also shows a part, but connection immediately disconnects and tries to connect again.
SSID is now twice in list of available networks, 1x Open, 1x WPA-PSK


[Blocking Requested - why for this release]: regression new in 2.1

Comment 1

[Jason Smith [:jsmith]]

QA Wanted for branch checks on Flame.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Eventually manage to get a stable connection to the network.
1. Forget the settings for the network.
2. First attempt to join the hidden network.
3. Go back to network list and wait 10-20 seconds until the network shows up in that list twice (1x WPA-PSK, 1x Open).
4. Tap on the WPA-PSK one and enter the password again and got connected.

Comment 3

[Chris Kreinbring [:CKreinbring]]

The bug repros on Flame 2.1 and Buri 2.1
Actual result: On attempting to join the hidden network, the attempt is seemingly not acknowledged.  After killing the settings app and returning to the WiFi page the hidden network is shown in the list as Open regardless of actual security.  Attempting to join will spawn a second listing of the hidden network with the actual security or connection status shown.

Flame 2.1
Build ID: 20140805074901
Gaia: e93780f9da8b34f370a4113abd4df9780d58e443
Gecko: 1aab16f74817
Platform Version: 34.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Buri 2.1
Build ID: 20140805081353
Gaia: e93780f9da8b34f370a4113abd4df9780d58e443
Gecko: b50bb656674e
Platform Version: 34.0a1
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------------------------------------------------------------------------

The bug does not repro on Flame 2.0
Actual result: On attempting to join the hidden network, the user is connected with no errors.  Returning to the main WiFi page will show only one listing of the hidden network, which has the correct connection or security status.

Build ID: 20140805064652
Gaia: 84af4f7a84d449165a2618fd5cfe4431bf156bfe
Gecko: 712836e6770a
Platform Version: 32.0
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 973466 landed on Gaia master on 2014-07-21, maybe that caused the regression.

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 973466 seems to have caused this issue.

B2g-inbound Regression Window

Last working 
Environmental Variables:
Device: Flame Master
BuildID: 20140721021717
Gaia: ba1890064fc71651e4ee5db451183e4f0a180aec
Gecko: d776423ddb87
Version: 33.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken 
Environmental Variables:
Device: Flame Master
BuildID: 20140721024717
Gaia: c9105b7e8e78495786c648197d92dc9b87c489ba
Gecko: eadb7cb9277c
Version: 33.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Last working gaia / First broken gecko - Issue does NOT occur
Gaia: ba1890064fc71651e4ee5db451183e4f0a180aec
Gecko: eadb7cb9277c

First broken gaia / Last working gecko - Issue DOES occur
Gaia: c9105b7e8e78495786c648197d92dc9b87c489ba
Gecko: d776423ddb87

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/ba1890064fc71651e4ee5db451183e4f0a180aec...c9105b7e8e78495786c648197d92dc9b87c489ba

Comment 6

[Joshua Mitchell (Inactive)]

broken by 973466 ? EJ - can you take a look?

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

OK, i'll check what's going on later, thanks.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8470593 [details] [review]
patch on master

Arthur,

can you give me some feedbacks about this patch ? Thanks !

I noticed that auth related functions are not working properly (may be missed) when refactoring, so I added it back and also tuned the others a little bit.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8470593 [details] [review]
patch on master

Take off ni? flag because i think this patch is ready for Arthur's review.

Thanks ;)

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8470593 [details] [review]
patch on master

Looks good to me, thanks!

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, just merged this patch into gaia/master : 

https://github.com/mozilla-b2g/gaia/commit/1723f2b3723da289a70d9bc5d0b2feaa4f91f402

Comment 13

[Sue]

Attachment: video of issue verify

This issue has been verified successfully on Flame 2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        8ae086c39011bc8842b2a19bb5267906fa22345a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebbd5c65c3c1
Build-ID        20141124094013
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141124.130744
FW-Date         Mon Nov 24 13:07:55 EST 2014
Bootloader      L1TC00011880

Comment 14

[Elie]

According Comment13 this issue has been verified successfully on Flame 2.1.So change the Status to "VERIFIED".