openh264 updates are not disabled on talos automation runs

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In bug 1026970, we're trying to enable MOZ_DISABLE_NONLOCAL_CONNECTIONS for talos too (it's currently only enabled for the main unit tests).

The latest try run found:

https://tbpl-dev.allizom.org/php/getParsedLog.php?id=45146248&tree=Try
14:01:34     INFO -  Running test tcanvasmark:
14:01:34     INFO -  		Started Sun, 03 Aug 2014 14:01:34
14:01:34     INFO -  DEBUG : operating with platform_type : linux_
14:01:34     INFO -  DEBUG : created profile
14:01:34     INFO -  DEBUG : command line: /builds/slave/talos-slave/test/build/application/firefox/firefox -profile /tmp/tmpyeVPpz/profile http://localhost/getInfo.html
14:01:43     INFO -  DEBUG : initialized firefox
14:01:43     INFO -  DEBUG : command line: /builds/slave/talos-slave/test/build/application/firefox/firefox -profile /tmp/tmpyeVPpz/profile -tp file:/home/cltbld/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/page_load_test/canvasmark/canvasmark.manifest -tpchrome -tpnoisy -tpcycles 5 -tppagecycles 1
14:02:45     INFO -  INFO : Browser exited with error code: 2816
14:02:50     INFO -  INFO : RSS: Main: 91336704
14:02:50     INFO -  1407099765072	GMPInstallManager.simpleCheckAndInstall	INFO	Last check was: 1407099765 seconds ago, minimum seconds: 86400
14:02:50     INFO -  1407099765073	GMPInstallManager._getURL	INFO	Using url: https://aus4.mozilla.org/update/3/GMP/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
14:02:50     INFO -  1407099765073	GMPInstallManager._getURL	INFO	Using url (with replacement): https://aus4.mozilla.org/update/3/GMP/34.0a1/20140803133033/Linux_x86-gcc3/en-US/default/Linux%203.2.0-38-generic-pae%20(GTK%202.24.10)/default/default/update.xml
14:02:50     INFO -  1407099765075	GMPInstallManager.checkForAddons	INFO	sending request to: https://aus4.mozilla.org/update/3/GMP/34.0a1/20140803133033/Linux_x86-gcc3/en-US/default/Linux%203.2.0-38-generic-pae%20(GTK%202.24.10)/default/default/update.xml
14:02:50     INFO -  FATAL ERROR: Non-local network connections are disabled and a connection attempt to aus4.mozilla.org (63.245.217.219) was made.
14:02:50     INFO -   You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.

To fix this, we need to just apply the same change to talos as was to prefs_general.js:
http://hg.mozilla.org/mozilla-central/diff/1f124b3a1355/testing/profiles/prefs_general.js
(Assignee)

Comment 1

5 years ago
At some point in the future I'd like to just make this list alphabetical, but for now...
Attachment #8467176 - Flags: review?(jmaher)
Comment on attachment 8467176 [details] [diff] [review]
Prevent GMPInstallManager from hitting the network

Review of attachment 8467176 [details] [diff] [review]:
-----------------------------------------------------------------

do we have a gmpplugin for mochitest?  I want to make sure there is no requirement for a gmpmanager-dummy/update.xml.
Attachment #8467176 - Flags: review?(jmaher) → review+
(Assignee)

Comment 3

5 years ago
The landing that regressed this was https://hg.mozilla.org/mozilla-central/rev/1f124b3a1355 - which didn't add a plugin to mochitest specifically. It is my understanding that the plugin ships with the browser by default, and that that bug was purely about making sure it's kept up to date on people's machines after that.
> It is my understanding that the plugin ships with the browser by default, 
> and that that bug was purely about making sure it's kept up to date on people's machines after that.

Thanks for fixing, the plugin gets installed and gets updated.
Even if the user doesn't have it, it will get installed.
It'll be a one time action for all installs.
thanks for the info!
Depends on: 1050824
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.