1048407 - Link to pushloghtml for "...and N more" changesets is not working

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2014-08-04 11.15.31.png

(disclaimer: I'm a treeherder noob who just stumbled across this)

When I click the "...and 26 more" link it takes me to https://treeherder.mozilla.org/pushloghtml?changeset=71497ed2e0db which is a page not found.

Comment 1

[Ed Morley [:emorley]]

Good spot - the URL should be:
https://hg.mozilla.org/mozilla-central/pushlog?changeset=71497ed2e0db

Thank you for filing! :-)

The link is generated here:
https://github.com/mozilla/treeherder-ui/blob/b7c39763c47fd7a47b4cc1367c9e990abfa4b023/webapp/app/index.html#L138

Comment 2

[Ed Morley [:emorley]]

In fact, it looks like the value of {{currentRepo.url}} has changed recently, since the box with an arrow on it, that is next to each individual commit SHA (which also uses {{currentRepo.url}}) is now pointing to: https://treeherder.mozilla.org/rev/8dd44718c3c5 too.

Comment 3

[Jonathan French (:jfrench)]

I just tried the most recent resultset (afcb3af79d09) on production just now, and the "and 69 more.." seems to be sending me to a valid link in a new tab - I believe.

https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=afcb3af79d09

When I click on the arrow box(es) to open each revision, I appear to get a correct url also.
https://hg.mozilla.org/mozilla-central/rev/afcb3af79d09

Comment 4

[Ed Morley [:emorley]]

Yeah works for me now, too.

Comment 5

[Cameron Dawson [:camd]]

I think this may be a race condition.  It works sometimes, but not others.  I have a fix that will eliminate the race condition.  But reopening this for now.  I'll check in the fix shortly.

Comment 6

[Cameron Dawson [:camd]]

Fixed in: https://github.com/mozilla/treeherder-ui/commit/eca6d6ab8774c7c4227a7c76e58e6804bb93f739

I made sure that the repositories endpoint and the resultset (without jobs) endpoint BOTH finished before trying to render the revisions, using ``$q.all``.  On the service end, we will also cache the list of repositories to speed that endpoint up a little. (separate service-side commit for that)

Comment 7

[Ed Morley [:emorley]]

That's great - thank you :-)

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/69d2238030fb58ac8f3a4e8eafeb342ce14faca6
fix bug 1048407: ensure the repository detail loads before the resultsets

https://github.com/mozilla/treeherder/commit/0597f4849b8608918350fdcccf1133f233e61845
Merge pull request #118 from mozilla/repo-query-serialize

fix bug 1048407: ensure the repository detail loads before the resultset...