Allow '-' in IDL identifiers (after the first character) and implement support for dictionaries whose members have a '-' in the name

RESOLVED FIXED in Firefox 33

Status

()

defect
RESOLVED FIXED
5 years ago
5 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

unspecified
mozilla34
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox33 fixed, firefox34 fixed)

Details

Attachments

(1 attachment)

This has come up a few times now.

I'm changing the definition of IDENTIFIER, but I could also just add a new DASHEDIDENTIFIER thing that's used as a dictionary member name, if preferred.

Cameron, thoughts?  I definitely think we want this for dictionaries; we've had several requests for it now.
Flags: needinfo?(cam)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8467237 [details] [diff] [review]
Allow dictionary members with '-' in the name

That seems fine.  The only place we use dashes in IDL syntax currently are for number literals and -Infinity, so we don't have any problem with ambiguity.
Attachment #8467237 - Flags: feedback?(cam) → feedback+
Flags: needinfo?(cam)
Comment on attachment 8467237 [details] [diff] [review]
Allow dictionary members with '-' in the name

Cameron, thanks!

I'm not likely to land this before the 19th, but people should feel free to do it ealier than that if it gets reviewed.
Attachment #8467237 - Flags: review?(khuey)
(In reply to On vacation Aug 5-18.  Please do not request review. from comment #4)
> Comment on attachment 8467237 [details] [diff] [review]
> Allow dictionary members with '-' in the name
> 
> Cameron, thanks!
> 
> I'm not likely to land this before the 19th, but people should feel free to
> do it ealier than that if it gets reviewed.

Since my patch is relying on this patch, I will make sure it lands as soon as I get the green lights from khuey.
https://hg.mozilla.org/mozilla-central/rev/dadbbe7b22f1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8467237 [details] [diff] [review]
Allow dictionary members with '-' in the name

Approval Request Comment
[Feature/regressing bug #]:
Dependency of bug 1033423

[User impact if declined]:
see uplift request in bug 1033423

[Describe test coverage new/current, TBPL]:
Landed on inbound on 2014-08-06 09:44:43 PDT:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dadbbe7b22f1

[Risks and why]:
Low risk because it additionally allows '-' in the names for dictionaries.

[String/UUID change made/needed]: none
Attachment #8467237 - Flags: approval-mozilla-aurora?
Attachment #8467237 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-testsuite+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.