1048437 - Allow '-' in IDL identifiers (after the first character) and implement support for dictionaries whose members have a '-' in the name

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This has come up a few times now.

I'm changing the definition of IDENTIFIER, but I could also just add a new DASHEDIDENTIFIER thing that's used as a dictionary member name, if preferred.

Cameron, thoughts?  I definitely think we want this for dictionaries; we've had several requests for it now.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Allow dictionary members with '-' in the name

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8467237 [details] [diff] [review]
Allow dictionary members with '-' in the name

That seems fine.  The only place we use dashes in IDL syntax currently are for number literals and -Infinity, so we don't have any problem with ambiguity.

Comment 3

[Cameron McCormack (:heycam)]

https://github.com/heycam/webidl/commit/4e6ef1f92d47ed9f962de5b63e263f0cc1ad2cbf

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8467237 [details] [diff] [review]
Allow dictionary members with '-' in the name

Cameron, thanks!

I'm not likely to land this before the 19th, but people should feel free to do it ealier than that if it gets reviewed.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to On vacation Aug 5-18.  Please do not request review. from comment #4)
> Comment on attachment 8467237 [details] [diff] [review]
> Allow dictionary members with '-' in the name
> 
> Cameron, thanks!
> 
> I'm not likely to land this before the 19th, but people should feel free to
> do it ealier than that if it gets reviewed.

Since my patch is relying on this patch, I will make sure it lands as soon as I get the green lights from khuey.

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dadbbe7b22f1

Comment 7

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/dadbbe7b22f1

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8467237 [details] [diff] [review]
Allow dictionary members with '-' in the name

Approval Request Comment
[Feature/regressing bug #]:
Dependency of bug 1033423

[User impact if declined]:
see uplift request in bug 1033423

[Describe test coverage new/current, TBPL]:
Landed on inbound on 2014-08-06 09:44:43 PDT:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dadbbe7b22f1

[Risks and why]:
Low risk because it additionally allows '-' in the names for dictionaries.

[String/UUID change made/needed]: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1bb9985d3223