1048583 - [spartacus] persona logout sometimes shows enter PIN

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect)

Description

[Kumar McMillan [:kumar]]

STR:
- start one purchase until you've at least created a PIN
- cancel it
- go back and log out from Marketplace settings
- search :paid
- tap buy button to start a new purchase

Sometimes I see the Persona Sign In button (for a second) on logout but then I see the enter PIN page. It should not show the enter PIN page.

Here were some logs:

E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/models/session.js:30 in SessionModel<.watchIdentity/<.onlogout: [model][session] Firing onlogout event
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:32 in PageView<.handlePersonaLogout: [view][page] Responding to onlogout event
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/lib/auth.js:159 in resetUser: [auth] Begin webpay user reset
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:64 in PageView<.handleLoginStateChange: [view][page] logged_in state changed to false
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:66 in PageView<.handleLoginStateChange: [view][page] Displaying login view.
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/app.js:30 in ViewManager/this.renderView: [view][app] Killing previous view instance.
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:19 in PageView<.initialize: [view][page] Page initialize
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:22 in PageView<.initialize: [view][page] Initializing event listeners
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/login.js:24 in LoginView<.render: [view][login] rendering login view
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/base.js:55 in renderTemplate: [view][base] Replacing $el with rendered content
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/models/session.js:34 in SessionModel<.watchIdentity/<.onready: [model][session] Firing onready event
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:49 in PageView<.handlePersonaReady: [view][page] Probably logged in, Persona never called back
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:51 in PageView<.handlePersonaReady: [view][page] Updating app.session: logged_in -> true
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:64 in PageView<.handleLoginStateChange: [view][page] logged_in state changed to true
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/models/transaction.js:61 in TransactionModel<.getNetworkCodes: [model][transaction] Using B2G 1.4+ mcc/mnc lookup
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:56 in PageView<.handlePersonaReady: [view][page] Updating app.session: user_hash -> false
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/lib/auth.js:168 in _resetSuccess: [auth] reset webpay user
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:122 in PageView<.setUpPayment/<: [view][page] Transaction started successfully
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:98 in PageView<.handlePinStateChange: [view][page] Checking changed pin state data
E/GeckoConsole(  292): Content JS LOG at http://fireplace.loc:7777/js/views/page.js:107 in PageView<.handlePinStateChange: [view][page] User has a pin so -> enter-pin

Comment 1

[Kumar McMillan [:kumar]]

this is actually happening to me all the time now :/

Comment 2

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/commit/ee3deb55d4c2de283a46ef80a1ebef3c0017b90d