Closed
Bug 1048636
Opened 9 years ago
Closed 6 years ago
Deprecate legacy comprehension expressions
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: shu, Unassigned)
References
Details
Attachments
(1 file)
2.10 KB,
patch
|
Waldo
:
review+
jorendorff
:
feedback+
|
Details | Diff | Splinter Review |
Parsing these is stuff of nightmares. And since these will never be standardized, we should remove them eventually. Start by deprecating.
Updated•9 years ago
|
Keywords: dev-doc-needed
Whiteboard: [DocArea=JS]
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8471243 -
Flags: review?(jwalden+bmo)
Attachment #8471243 -
Flags: feedback?(jorendorff)
Comment 2•9 years ago
|
||
Comment on attachment 8471243 [details] [diff] [review] Deprecate legacy generator expressions. Review of attachment 8471243 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/js.msg @@ +441,5 @@ > MSG_DEF(JSMSG_PROXY_CONSTRUCT_OBJECT, 387, 0, JSEXN_TYPEERR, "proxy [[Construct]] must return an object") > MSG_DEF(JSMSG_PROXY_GETOWN_OBJORUNDEF, 388, 0, JSEXN_TYPEERR, "proxy [[GetOwnProperty]] must return an object or undefined") > MSG_DEF(JSMSG_CANT_REPORT_C_AS_NC, 389, 0, JSEXN_TYPEERR, "proxy can't report existing configurable property as non-configurable") > MSG_DEF(JSMSG_COMP_PROP_UNTERM_EXPR, 390, 0, JSEXN_SYNTAXERR, "missing ] in computed property name") > +MSG_DEF(JSMSG_DEPRECATED_GENEXPR, 391, 0, JSEXN_SYNTAXERR, "parenthesized generator expressions are deprecated; use yield instead") Hmm, "use yield instead" rather under-describes it. And this whole ES6 removing generators thing makes for even more sadfaces in what to say. I dunno, this is horrible, but I spent too long reviewing another patch today, not going to distract myself by this badness now. Someone more motivated can offer a better suggestion.
Attachment #8471243 -
Flags: review?(jwalden+bmo) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8471243 [details] [diff] [review] Deprecate legacy generator expressions. Review of attachment 8471243 [details] [diff] [review]: ----------------------------------------------------------------- "use ES6 generators instead"
Attachment #8471243 -
Flags: feedback?(jorendorff) → feedback+
Comment 4•6 years ago
|
||
Legacy generator comprehensions were removed in bug 1220564, resolving as Won't Fix.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Keywords: dev-doc-needed
Whiteboard: [DocArea=JS]
You need to log in
before you can comment on or make changes to this bug.
Description
•