Closed
Bug 1048682
Opened 11 years ago
Closed 11 years ago
Fix failing jspinyin unit tests
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S2 (15aug)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: rudyl, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
It turns out that I forgot to update the jspinyin unit tests because they won't be run on TBPL, tracked by bug 1031163 to re-enable them.
This bug is used to fix them so that it won't fail on Travis for each build test.
|
Assignee | |
Comment 1•11 years ago
|
||
Luke,
Could you help review this patch?
Thank you.
Attachment #8467519 -
Flags: review?(lchang)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8467519 [details] [review]
Patch V1
Seems Luke is taking PTO today.
Yuan, could you please help review this?
Thank you.
Attachment #8467519 -
Flags: review?(lchang) → review?(xyuan)
|
||
Comment 3•11 years ago
|
||
Yes, I'll review it soon.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Yuan,
Thank you. :)
|
|
Assignee | |
Comment 5•11 years ago
|
||
I've done a test run on Travis using my own repo,
https://travis-ci.org/RudyLu/gaia/builds/31677491
The result is passed.
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → rlu
Status: NEW → ASSIGNED
|
|
||
Updated•11 years ago
|
Attachment #8467519 -
Flags: review?(xyuan) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/33516d6fa71fd314c51b3856d0a8a85d5da23d2d
--
Yuan, thanks for the review.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
status-b2g-v2.1:
--- → fixed
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•