1048719 - WebGL2 - Implement WebGLQuery

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

Implement functions and types to support WebGLQuery object.

Comment 1

[u480271]

Attachment: [WebGL2] Query objects

Moved the previous implementation to keep the theme.

Comment 2

[Kelsey Gilbert [:jgilbert] (previously Jeff)]

Comment on attachment 8527390 [details] [diff] [review]
[WebGL2] Query objects

Review of attachment 8527390 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextQueries.cpp
@@ +8,1 @@
>  #include "GLContext.h"

Alphabetical, with parent header on top.

@@ +24,5 @@
> +GetQueryTargetEnumString(GLenum target)
> +{
> +    switch (target)
> +    {
> +        case LOCAL_GL_ANY_SAMPLES_PASSED:

I'm assuming this file is basically just moved code.

::: dom/canvas/WebGLQuery.cpp
@@ +28,5 @@
>      mContext->gl->fGenQueries(1, &mGLName);
>  }
>  
> +void
> +WebGLQuery::Delete() {

{ on next line.

Comment 3

[u480271]

(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> I'm assuming this file is basically just moved code.

Exactly what I mean by comment #1

Comment 4

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=d24fa6dbab83

Comment 5

[u480271]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5bccb2e00cb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5bccb2e00cb

Comment 7

[u480271]

Attachment: [WebGL2] remove WebGLQueryRefPtr typedef

Comment 8

[u480271]

This slipped through.

Comment 9

[Kelsey Gilbert [:jgilbert] (previously Jeff)]

Comment on attachment 8528785 [details] [diff] [review]
[WebGL2] remove WebGLQueryRefPtr typedef

You seem to have color codes in your diff here. The changes are r+ though.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af5fc587f98b

Comment 11

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/API/WebGLQuery