WebGL2 - Implement WebGLQuery

RESOLVED FIXED in mozilla36

Status

()

Product:
Core
Component:
Canvas: WebGL
Type:
defect
Status:
RESOLVED FIXED
Opened:
5 years ago
Updated:
3 years ago

People

(Reporter: kamidphish, Assigned: kamidphish)

Tracking

({dev-doc-complete})

Version:
unspecified
Target:
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(
URL
)

Attachments

(2 attachments)

[WebGL2] Query objects
33.75 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review
[WebGL2] remove WebGLQueryRefPtr typedef
2.91 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review 
Implement functions and types to support WebGLQuery object.
Moved the previous implementation to keep the theme.
Attachment #8527390 - Flags: review?(jgilbert)
Comment on attachment 8527390 [details] [diff] [review]
[WebGL2] Query objects

Review of attachment 8527390 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextQueries.cpp
@@ +8,1 @@
>  #include "GLContext.h"

Alphabetical, with parent header on top.

@@ +24,5 @@
> +GetQueryTargetEnumString(GLenum target)
> +{
> +    switch (target)
> +    {
> +        case LOCAL_GL_ANY_SAMPLES_PASSED:

I'm assuming this file is basically just moved code.

::: dom/canvas/WebGLQuery.cpp
@@ +28,5 @@
>      mContext->gl->fGenQueries(1, &mGLName);
>  }
>  
> +void
> +WebGLQuery::Delete() {

{ on next line.
Attachment #8527390 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> I'm assuming this file is basically just moved code.

Exactly what I mean by comment #1
https://hg.mozilla.org/mozilla-central/rev/e5bccb2e00cb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
This slipped through.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8528785 [details] [diff] [review]
[WebGL2] remove WebGLQueryRefPtr typedef

You seem to have color codes in your diff here. The changes are r+ though.
Attachment #8528785 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/af5fc587f98b
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.