Closed
Bug 1048719
Opened 7 years ago
Closed 6 years ago
WebGL2 - Implement WebGLQuery
Categories
(Core :: Canvas: WebGL, defect)
Core
Canvas: WebGL
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: djg, Assigned: djg)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
33.75 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
2.91 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Implement functions and types to support WebGLQuery object.
Updated•7 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 1•6 years ago
|
||
Moved the previous implementation to keep the theme.
Attachment #8527390 -
Flags: review?(jgilbert)
Comment 2•6 years ago
|
||
Comment on attachment 8527390 [details] [diff] [review] [WebGL2] Query objects Review of attachment 8527390 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGL2ContextQueries.cpp @@ +8,1 @@ > #include "GLContext.h" Alphabetical, with parent header on top. @@ +24,5 @@ > +GetQueryTargetEnumString(GLenum target) > +{ > + switch (target) > + { > + case LOCAL_GL_ANY_SAMPLES_PASSED: I'm assuming this file is basically just moved code. ::: dom/canvas/WebGLQuery.cpp @@ +28,5 @@ > mContext->gl->fGenQueries(1, &mGLName); > } > > +void > +WebGLQuery::Delete() { { on next line.
Attachment #8527390 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #2) > I'm assuming this file is basically just moved code. Exactly what I mean by comment #1
Assignee | ||
Comment 4•6 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d24fa6dbab83
Assignee | ||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5bccb2e00cb
Comment 6•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e5bccb2e00cb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 7•6 years ago
|
||
Attachment #8528785 -
Flags: review?(jgilbert)
Assignee | ||
Comment 8•6 years ago
|
||
This slipped through.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•6 years ago
|
||
Comment on attachment 8528785 [details] [diff] [review] [WebGL2] remove WebGLQueryRefPtr typedef You seem to have color codes in your diff here. The changes are r+ though.
Attachment #8528785 -
Flags: review?(jgilbert) → review+
Comment 10•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/af5fc587f98b
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Comment 11•5 years ago
|
||
https://developer.mozilla.org/en-US/docs/Web/API/WebGLQuery
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•