Closed Bug 1048721 Opened 6 years ago Closed 6 years ago

WebGL2 - Implement WebGLSync

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: djg, Assigned: djg)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Implement functions and types to support WebGLSync object.
Blocks: webgl2
Attachment #8579685 - Flags: review?(jgilbert)
Comment on attachment 8579685 [details] [diff] [review]
Implement WebGL2Sync.

Review of attachment 8579685 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLSync.h
@@ +20,5 @@
>  {
>      friend class WebGL2Context;
>  
>  public:
> +    explicit WebGLSync(WebGLContext* webgl, GLsync name);

I'd rather make this RAII, instead of passing some externally-created GLsync in. (Also, `explicit` is only for single-arg ctors, IIRC)
Attachment #8579685 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #4)
> > +    explicit WebGLSync(WebGLContext* webgl, GLsync name);
> 
> I'd rather make this RAII, instead of passing some externally-created GLsync
> in. (Also, `explicit` is only for single-arg ctors, IIRC)

We can do that. I think I changed to this why because of how we pass in the glname for other objects, such as textures, render buffers, frame buffers, etc.

Good spot on explicit. This function used to be single-arg ctor.
https://hg.mozilla.org/mozilla-central/rev/f5957afe1f8d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.