Closed
Bug 1048721
Opened 9 years ago
Closed 9 years ago
WebGL2 - Implement WebGLSync
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: u480271, Assigned: u480271)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
6.86 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
2.34 KB,
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
Implement functions and types to support WebGLSync object.
Updated•9 years ago
|
Keywords: dev-doc-needed
Attachment #8579685 -
Flags: review?(jgilbert)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9c8807623a9
Status: NEW → ASSIGNED
Comment 4•9 years ago
|
||
Comment on attachment 8579685 [details] [diff] [review] Implement WebGL2Sync. Review of attachment 8579685 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLSync.h @@ +20,5 @@ > { > friend class WebGL2Context; > > public: > + explicit WebGLSync(WebGLContext* webgl, GLsync name); I'd rather make this RAII, instead of passing some externally-created GLsync in. (Also, `explicit` is only for single-arg ctors, IIRC)
Attachment #8579685 -
Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #4) > > + explicit WebGLSync(WebGLContext* webgl, GLsync name); > > I'd rather make this RAII, instead of passing some externally-created GLsync > in. (Also, `explicit` is only for single-arg ctors, IIRC) We can do that. I think I changed to this why because of how we pass in the glname for other objects, such as textures, render buffers, frame buffers, etc. Good spot on explicit. This function used to be single-arg ctor.
Attachment #8580439 -
Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f5957afe1f8d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment 9•8 years ago
|
||
https://developer.mozilla.org/en-US/docs/Web/API/WebGL2RenderingContext#Sync_objects
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•