1048721 - WebGL2 - Implement WebGLSync

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

Implement functions and types to support WebGLSync object.

Comment 1

[u480271]

https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.12

Comment 2

[u480271]

Attachment: Implement WebGL2Sync.

Comment 3

[u480271]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9c8807623a9

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8579685 [details] [diff] [review]
Implement WebGL2Sync.

Review of attachment 8579685 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLSync.h
@@ +20,5 @@
>  {
>      friend class WebGL2Context;
>  
>  public:
> +    explicit WebGLSync(WebGLContext* webgl, GLsync name);

I'd rather make this RAII, instead of passing some externally-created GLsync in. (Also, `explicit` is only for single-arg ctors, IIRC)

Comment 5

[u480271]

(In reply to Jeff Gilbert [:jgilbert] from comment #4)
> > +    explicit WebGLSync(WebGLContext* webgl, GLsync name);
> 
> I'd rather make this RAII, instead of passing some externally-created GLsync
> in. (Also, `explicit` is only for single-arg ctors, IIRC)

We can do that. I think I changed to this why because of how we pass in the glname for other objects, such as textures, render buffers, frame buffers, etc.

Good spot on explicit. This function used to be single-arg ctor.

Comment 6

[u480271]

Attachment: Address review comments.

Comment 7

[u480271]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5957afe1f8d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f5957afe1f8d

Comment 9

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/API/WebGL2RenderingContext#Sync_objects