1048743 - WebGL2 - Implement Programs and Shaders

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.6

Comment 1

[u480271]

Attachment: [WebGL2] No support for binary shaders

Comment 2

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=b400100fb2e2

Comment 3

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=22098a327b98

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8524366 [details] [diff] [review]
[WebGL2] No support for binary shaders

Review of attachment 8524366 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextState.cpp
@@ +191,5 @@
>                  return WebGLObjectAsJSValue(cx, mBound3DTextures[mActiveTexture].get(), rv);
>              }
> +
> +            case LOCAL_GL_NUM_PROGRAM_BINARY_FORMATS:
> +                return JS::NumberValue(0);

I believe this should be done at the emscripten glue level. If WebGL2 doesn't support binary formats, we shouldn't even expose these entrypoints.

Comment 5

[u480271]

Moved the check to emscripten.

https://github.com/kripken/emscripten/pull/3014

Comment 6

[u480271]

Comment on attachment 8524366 [details] [diff] [review]
[WebGL2] No support for binary shaders

># HG changeset patch
># User Dan Glastonbury <[e-mail]>
># Date 1414366783 -36000
>#      Mon Oct 27 09:39:43 2014 +1000
># Node ID 144aac1bcb00b801efddeb705b3536628ee81d23
># Parent  c74f8b801a5d40bb7aa3c41f30cf5244d6e731aa
>Bug 1048743 - [WebGL2] No support for binary shaders. r=jgilbert
>
>diff --git a/dom/canvas/WebGLContextState.cpp b/dom/canvas/WebGLContextState.cpp
>--- a/dom/canvas/WebGLContextState.cpp
>+++ b/dom/canvas/WebGLContextState.cpp
>@@ -185,16 +185,19 @@ WebGLContext::GetParameter(JSContext* cx
>                 GLint val;
>                 gl->fGetIntegerv(pname, &val);
>                 return JS::NumberValue(uint32_t(val));
>             }
> 
>             case LOCAL_GL_TEXTURE_BINDING_3D: {
>                 return WebGLObjectAsJSValue(cx, mBound3DTextures[mActiveTexture].get(), rv);
>             }
>+
>+            case LOCAL_GL_NUM_PROGRAM_BINARY_FORMATS:
>+                return JS::NumberValue(0);
>         }
>     }
> 
>     switch (pname) {
>         //
>         // String params
>         //
>         case LOCAL_GL_VENDOR:

Comment 7

[Jeff Muizelaar [:jrmuizel]]

I believe we can call this fixed.