1048749 - NFCD: Add assert when receiving NDEF from P2P

Status: RESOLVED DUPLICATE of bug 1048763

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Junichi-san has mentioned that they found that a NDEF is received from a P2P link before the P2P link is activated, (i.e. the techList [NDEF, P2P] come before [P2P]),
this is unlikely to happen so we could add an assert in this.

Also reset SessionId when it comes to INT_MAX.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Pull Request

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Just a general remark: asserts are only for validating internal state; not for input data.

The assert will terminate the program, which makes DOS attacks trivial. But if you build for releases, the assert will usually be removed, which is also bad because you loose your input validation.

Comment 3

[Dimi Lee [:dimi]]

Hi Yoshi,
Could you separate the fixs ,I cannot review the case that NDEF is received before a P2P link is established unless i know how it happens.