Closed
Bug 1048780
Opened 11 years ago
Closed 11 years ago
Use matches() rather than mozMatchesSelector()
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
94.27 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
They're equivalent, so we should use the standard one.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8467698 -
Flags: review?(jst)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8467698 [details] [diff] [review]
Call the standard matches() rather than the proprietary mozMatchesSelector()
Did you leave at least one case where we test the mozMatchesSelector() method as well? IOW, we should test both, at least trivially.
r=jst, thanks!
Attachment #8467698 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•