1048784 - Button 'OK' for dialog about invalid email address should either be centered or use full width, currently on the left

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox OS 2.1.0.0-prerelease 20140803221934 on Geeksphone Keon

When composing an email with an invalid recipient (e.g. "foo") and trying to send it, the app shows an error message whose "OK" button at the bottom is on the left, but should be centered (and use the full width, it seems).

Comment 1

[James Burke [:jrburke]]

Attachment: GitHub pull request

It was just missing the "full" class supported by shared/style/confirm.css that makes the button full width size. Tested and fixes the button so that it stretches the full width with the OK text centered.

Comment 2

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/d267155f87c6f21d8214cf38e59856e4dfd26cbf

from pull request:
https://github.com/mozilla-b2g/gaia/pull/22544

Comment 3

[Edward Chen[:edchen]]

[Environment]
Gaia      c8e93dadeaec6a2617b4db8b7d65ba14aa8db378
Gecko     https://hg.mozilla.org/mozilla-central/rev/c14e5feadc61
BuildID   20140821160203
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014


[Result]
PASS