Closed Bug 1048979 Opened 5 years ago Closed 5 years ago

Search engine icons should be limited to 16px

Categories

(SeaMonkey :: Themes, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.31

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files, 1 obsolete file)

Steps to reproduce problem:
1. Install e.g. the Bulbapedia search engine
2. Select it as your current search engine
3. Start typing in the URLbar

Expected result: 16×16px Bulbapedia icon

Actual result: 32×32px Bulbapedia icon
Attached patch Proposed patch (obsolete) — Splinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8467877 - Flags: review?(philip.chee)
STR:
1. Install the modified firefox amazondotcom.xml[1] from this attachment. Image is 130x52
2. Select it as your current search engine
3. Start typing in the URLbar

Actual: With your patch the Amazon image is squished into a 16x16 image.

Expected: image is scaled to maintain proportions e.g. 40x16px

[1] http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/searchplugins/amazondotcom.xml?rev=0e734989df76#11
Suggest you fix the height to 16px and let the horizontal dimension scale automatically.
(In reply to Philip Chee from comment #2)
> STR:
> 1. Install the modified firefox amazondotcom.xml[1] from this attachment.
> Image is 130x52
> 2. Select it as your current search engine
> 3. Start typing in the URLbar
> 
> Actual: With your patch the Amazon image is squished into a 16x16 image.
> 
> Expected: image is scaled to maintain proportions e.g. 40x16px

I tried this in Firefox, although it was harder than expected as it kept on wanting to use its internal xml file from somewhere, even in a new profile, and the image is squished into a 16×16 image in both places where I could find it.

On the other hand it did let me find more places in SeaMonkey where it's not squished to 16×16 although you would expect it to be.
Attached patch Revised patchSplinter Review
The change from padding to margin in Modern's menulist.xml also fixes the display of the File Bookmark dialog, and allowed me to remove an override from prefpanels.css, so I thought it was better than propagating the workaround.
Attachment #8467877 - Attachment is obsolete: true
Attachment #8467877 - Flags: review?(philip.chee)
Attachment #8470897 - Flags: review?(stefanh)
Attachment #8470897 - Flags: review?(iann_bugzilla)
Comment on attachment 8470897 [details] [diff] [review]
Revised patch

Mac classic looks fine, thanks.
Attachment #8470897 - Flags: review?(stefanh) → review+
Comment on attachment 8470897 [details] [diff] [review]
Revised patch

r=me and a=me for CLOSED TREE
Attachment #8470897 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset 321bb7922713.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.31
You need to log in before you can comment on or make changes to this bug.