1048979 - Search engine icons should be limited to 16px

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Install e.g. the Bulbapedia search engine
2. Select it as your current search engine
3. Start typing in the URLbar

Expected result: 16×16px Bulbapedia icon

Actual result: 32×32px Bulbapedia icon

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

Attachment: amazondotcom.xml with 130x52 dimensions.

STR:
1. Install the modified firefox amazondotcom.xml[1] from this attachment. Image is 130x52
2. Select it as your current search engine
3. Start typing in the URLbar

Actual: With your patch the Amazon image is squished into a 16x16 image.

Expected: image is scaled to maintain proportions e.g. 40x16px

[1] http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/searchplugins/amazondotcom.xml?rev=0e734989df76#11

Comment 3

[Philip Chee]

Suggest you fix the height to 16px and let the horizontal dimension scale automatically.

Comment 4

[[e-mail]]

(In reply to Philip Chee from comment #2)
> STR:
> 1. Install the modified firefox amazondotcom.xml[1] from this attachment.
> Image is 130x52
> 2. Select it as your current search engine
> 3. Start typing in the URLbar
> 
> Actual: With your patch the Amazon image is squished into a 16x16 image.
> 
> Expected: image is scaled to maintain proportions e.g. 40x16px

I tried this in Firefox, although it was harder than expected as it kept on wanting to use its internal xml file from somewhere, even in a new profile, and the image is squished into a 16×16 image in both places where I could find it.

On the other hand it did let me find more places in SeaMonkey where it's not squished to 16×16 although you would expect it to be.

Comment 5

[[e-mail]]

Attachment: Revised patch

The change from padding to margin in Modern's menulist.xml also fixes the display of the File Bookmark dialog, and allowed me to remove an override from prefpanels.css, so I thought it was better than propagating the workaround.

Comment 6

[Stefan [:stefanh]]

Comment on attachment 8470897 [details] [diff] [review]
Revised patch

Mac classic looks fine, thanks.

Comment 7

[Ian Neal]

Comment on attachment 8470897 [details] [diff] [review]
Revised patch

r=me and a=me for CLOSED TREE

Comment 8

[[e-mail]]

Pushed comm-central changeset 321bb7922713.