1048985 - Mozharness/buildbotcustom should match against TEST-UNEXPECTED-FAIL even if not at start of the line

Status: RESOLVED INCOMPLETE

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Ed Morley [:emorley]]

Broken out from bug 1048423 comment 2 & also bug 1028119 comment 8.

tl;dr if the harness missed a TEST-UNEXPECTED-FAIL, the job will still turn orange iff the TEST-UNEXPECTED-FAIL is at the start of the line.

In an ideal world the harness would be perfect, and we'd rely solely on it's summary and the return code, however whilst we still check for TEST-UNEXPECTED-FAIL within mozharness/buildbotcustom, we should just remove the start of line anchor.

mozharness:
http://mxr.mozilla.org/build-central/search?string=TEST-UNEXPECTED&case=1&find=%2Fmozharness%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=build-central

buildbotcustom:
http://mxr.mozilla.org/build-central/search?string=TEST-UNEXPECTED&case=1&find=%2Fbuildbotcustom%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=build-central

Comment 2

[Ahmed Kachkach [:akachkach]]

Fixing this would allow us to switch structured logging back for the harness-generated logs (where we switched to unstructured logs because of the formatting difference).