1049003 - Refractor AppMenucomponent to wait for menu to update before finding a menu item

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Comment 1

[Vivek Balakrishnan[:vivek]]

Description :
This is a followup to bug 996227. As mentioned https://bugzilla.mozilla.org/show_bug.cgi?id=1034261#c12, it was observed while testing that sub menu take a while to update. So, findMenu function must wait for the menu to update with a possible timeout before finding the actual menu item.

Comment 2

[Vivek Balakrishnan[:vivek]]

Attachment: 1049003.patch

A patch where findAppMenuItemView wait for the menu text to appear before proceeding.

Comment 3

[Vivek Balakrishnan[:vivek]]

Attachment: 1049003.patch

Patch updated with minor correction.

Comment 4

[Vivek Balakrishnan[:vivek]]

Attachment: 1049003_updated.patch

Patch fixed. Now patch waits for menu item to appear before checking for menu item states.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8468791 [details] [diff] [review]
1049003_updated.patch

Review of attachment 8468791 [details] [diff] [review]:
-----------------------------------------------------------------

Does this work? Is this all we need? Do you have a try run to show it?

::: mobile/android/base/tests/components/AppMenuComponent.java
@@ +144,5 @@
>       *
>       * This method is dependent on not having two views with equivalent contentDescription / text.
>       */
>      private View findAppMenuItemView(String text) {
> +        mSolo.waitForText(text, 1, MAX_WAITTIME_FOR_MENU_UPDATE_IN_MS);

We should probably fill out all the parameters for waitForText (scroll & onlyVisible).

Comment 6

[Vivek Balakrishnan[:vivek]]

Try server logs:
https://tbpl.mozilla.org/?tree=Try&rev=788c07943ae1

The tested patch contains changes related to bug 1049003 and its dependent bug 1034261

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Are we thinking the robocop-5 failures that hit in 3/4 runs are spurious?

https://tbpl.mozilla.org/php/getParsedLog.php?id=45865080&tree=Try

10:46:20     INFO -  195 INFO SimpleTest START
10:46:20     INFO -  196 INFO TEST-START | testAppMenuPathways
10:46:20     INFO -  197 INFO TEST-PASS | testAppMenuPathways | Given message occurred for registered event: {"type":"Gecko:Ready"} - Gecko:Ready should equal Gecko:Ready
10:46:20     INFO -  198 INFO EventExpecter: no longer listening for Gecko:Ready
10:46:20     INFO -  199 INFO TEST-PASS | testAppMenuPathways | Menu is not open -
10:46:20     INFO -  200 INFO TEST-PASS | testAppMenuPathways | Waiting for menu to open. -
10:46:20     INFO -  201 INFO TEST-PASS | testAppMenuPathways | The parent 'page' menu item is not enabled -
10:46:20     INFO -  202 INFO TEST-PASS | testAppMenuPathways | The parent 'page' menu item is visible - 0 should equal 0
10:46:20     INFO -  203 INFO TEST-PASS | testAppMenuPathways | url is not null - /robocop/robocop_blank_01.html should not equal null
10:46:20     INFO -  204 INFO TEST-PASS | testAppMenuPathways | url is not null - /robocop/robocop_blank_01.html should not equal null
10:46:20     INFO -  205 INFO TEST-PASS | testAppMenuPathways | The toolbar is not in the editing state -
10:46:20     INFO -  206 INFO TEST-PASS | testAppMenuPathways | Waiting for Toolbar to enter editing mode. -
10:46:20     INFO -  207 INFO TEST-PASS | testAppMenuPathways | Waiting for UrlEditText to be input method target. -
10:46:20     INFO -  208 INFO TEST-PASS | testAppMenuPathways | url is not null - http://mochi.test:8888/tests/robocop/robocop_blank_01.html should not equal null
10:46:20     INFO -  209 INFO TEST-PASS | testAppMenuPathways | The toolbar is in the editing state -
10:46:20     INFO -  210 INFO TEST-PASS | testAppMenuPathways | The UrlEditText is the input method target -
10:46:20     INFO -  211 INFO TEST-PASS | testAppMenuPathways | The toolbar is in the editing state -
10:46:20     INFO -  212 INFO TEST-PASS | testAppMenuPathways | initiatingAction is not null - org.mozilla.gecko.tests.components.ToolbarComponent$2@41326fc8 should not equal null
10:46:20     INFO -  213 INFO ToolbarTitleTextChangeVerifier: stored title, "".
10:46:20     INFO -  214 INFO TEST-PASS | testAppMenuPathways | Given message occurred for registered event: {"type":"DOMTitleChanged","title":"Browser Blank Page 01","tabID":0} - DOMTitleChanged should equal DOMTitleChanged
10:46:20     INFO -  215 INFO TEST-PASS | testAppMenuPathways | Given message occurred for registered event: {"bgColor":"transparent","errorType":"","type":"DOMContentLoaded","metadata":null,"tabID":0} - DOMContentLoaded should equal DOMContentLoaded
10:46:20     INFO -  216 INFO EventExpecter: no longer listening for DOMContentLoaded
10:46:20     INFO -  217 INFO EventExpecter: no longer listening for DOMTitleChanged
10:46:20     INFO -  218 INFO ToolbarTitleTextChangeVerifier: state changed to title, "Browser Blank Page 01".
10:46:20     INFO -  219 INFO ToolbarTitleTextChangeVerifier: was satisfied.
10:46:20     INFO -  220 INFO TEST-PASS | testAppMenuPathways | Waiting for Toolbar to exit editing mode. -
10:46:20     INFO -  221 INFO TEST-PASS | testAppMenuPathways | The toolbar is not in the editing state -
10:46:20     INFO -  222 INFO TEST-PASS | testAppMenuPathways | The Toolbar title is Browser Blank Page 01 - Browser Blank Page 01 should equal Browser Blank Page 01
10:46:20     INFO -  223 INFO TEST-PASS | testAppMenuPathways | Menu is not open -
10:46:20     INFO -  224 INFO TEST-PASS | testAppMenuPathways | Waiting for menu to open. -
10:46:20     INFO -  225 INFO TEST-PASS | testAppMenuPathways | Menu is open -
10:46:20     INFO -  226 INFO TEST-PASS | testAppMenuPathways | The menu item Page is enabled -
10:46:20     INFO -  227 INFO TEST-PASS | testAppMenuPathways | The menu item Page is visible - 0 should equal 0
10:46:20     INFO -  228 INFO TEST-PASS | testAppMenuPathways | Menu is open -
10:46:20     INFO -  229 INFO TEST-PASS | testAppMenuPathways | The menu item Save as PDF is enabled -
10:46:20     INFO -  230 INFO TEST-PASS | testAppMenuPathways | The menu item Save as PDF is visible - 0 should equal 0
10:46:20     INFO -  231 INFO TEST-PASS | testAppMenuPathways | Menu is not open -
10:46:20     INFO -  232 INFO TEST-UNEXPECTED-FAIL | testAppMenuPathways | Waiting for menu to open. -
10:46:20     INFO -  TEST-INFO | expected PASS
10:46:20     INFO -  233 INFO TEST-OK | testAppMenuPathways | took 46050ms

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> Are we thinking the robocop-5 failures that hit in 3/4 runs are spurious?

When I initially looked at the rc test, I saw 1 fail and 1 pass: the failure seemed unrelated but perhaps we've uncovered a race condition.

Vivek, do you mind taking a look?

Comment 9

[Vivek Balakrishnan[:vivek]]

As discussed over IRC, I'll submit a new patch for bug 1034261 swapping the tests.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/4b558c9c4a24

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b558c9c4a24