Create global configuration file for Gaia performance testing

RESOLVED FIXED in 2.1 S2 (15aug)

Status

Firefox OS
Gaia::PerformanceTest
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Eli, Assigned: Eli)

Tracking

({perf})

unspecified
2.1 S2 (15aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c=automation p=3 s=2014.08.15 u=])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Gaia performance tests do not have a unified file for sharing configuration or constant data. Adding an INI file to the gaia/tests/performance directory and including an easy mechanism for consumption would improve maintenance.

Updated

4 years ago
Blocks: 972240, 972155
(Assignee)

Updated

4 years ago
Blocks: 1044297
(Assignee)

Comment 1

4 years ago
Created attachment 8468160 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22545/files

First pass at implementing a global mechanism for holding performance testing utilities and configuration. Obviously this is a good-sized change with a bit of refactoring to take advantage of the new configuration and utilities. Also the format of the config file is open for discussion as well, I'd be happy to explain my logic behind this. :)
Attachment #8468160 - Flags: review?(hub)
(Assignee)

Comment 2

4 years ago
Also, I've tested this locally using:

APP=settings RUNS=10 make test-perf
VERBOSE=1 APP=communications/dialer make test-perf
APP=email RUNS=1 make test-perf

All tests ran fine with no errors, and all environment variables were recognized and respected.
(Assignee)

Comment 3

4 years ago
Hub, just a note that the "goals" config section is just a placeholder and will be replaced with whatever data structure you deem fit for consumption.

Updated

4 years ago
Blocks: 1007774
I did comment on the PR.
(Assignee)

Comment 5

4 years ago
PR updated with comments addressed.
Comment on attachment 8468160 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22545/files

Ship it !

(you ran the test after these changes, didn't you?)
Attachment #8468160 - Flags: review?(hub) → review+
(Assignee)

Comment 7

4 years ago
Thanks Hub! And yes, I ran the same command set as before to be sure.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Whiteboard: [c=automation p=2 s= u=] → [c=automation p=3 s= u=]
Merged
https://github.com/mozilla-b2g/gaia/commit/c49a3bab7caaee18d830448820f0f7082622b450
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
(Assignee)

Updated

4 years ago
Whiteboard: [c=automation p=3 s= u=] → [c=automation p=3 s=2014.08.15 u=]
You need to log in before you can comment on or make changes to this bug.