52 bytes, text/plain
Gaia performance tests do not have a unified file for sharing configuration or constant data. Adding an INI file to the gaia/tests/performance directory and including an easy mechanism for consumption would improve maintenance.
Created attachment 8468160 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22545/files First pass at implementing a global mechanism for holding performance testing utilities and configuration. Obviously this is a good-sized change with a bit of refactoring to take advantage of the new configuration and utilities. Also the format of the config file is open for discussion as well, I'd be happy to explain my logic behind this. :)
Attachment #8468160 - Flags: review?(hub)
Also, I've tested this locally using: APP=settings RUNS=10 make test-perf VERBOSE=1 APP=communications/dialer make test-perf APP=email RUNS=1 make test-perf All tests ran fine with no errors, and all environment variables were recognized and respected.
Hub, just a note that the "goals" config section is just a placeholder and will be replaced with whatever data structure you deem fit for consumption.
I did comment on the PR.
PR updated with comments addressed.
Comment on attachment 8468160 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22545/files Ship it ! (you ran the test after these changes, didn't you?)
Attachment #8468160 - Flags: review?(hub) → review+
Thanks Hub! And yes, I ran the same command set as before to be sure.
Whiteboard: [c=automation p=2 s= u=] → [c=automation p=3 s= u=]
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
Whiteboard: [c=automation p=3 s= u=] → [c=automation p=3 s=2014.08.15 u=]
You need to log in before you can comment on or make changes to this bug.