Closed Bug 1049035 Opened 5 years ago Closed 5 years ago

System JS : WARNING resource://gre/modules/HealthReport.jsm:1037 - variable msg redeclares argument

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Noticed this go by in my debug-build spew:
{
System JS : WARNING resource://gre/modules/HealthReport.jsm:1037 - variable msg redeclares argument
}

This is from this code (in a file that's unified into HealthReport.jsm):
> 530   _recordProviderError: function (name, msg, ex) {
> 531     let msg = "Provider error: " + name + ": " + msg;

http://mxr.mozilla.org/mozilla-central/source/services/metrics/providermanager.jsm#531

I think we can just drop the "let" there.

Marking as blocking bug 845431, since that's what added this chunk of code.
(In reply to Daniel Holbert [:dholbert] from comment #0)
> Marking as blocking bug 845431, since that's what added this chunk of code.

er, "Marking as depending on"
Attached patch fix v1Splinter Review
Dropping "let".
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8467932 - Flags: review?(gps)
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Attachment #8467932 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/8d044c5d7c92
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.