1049035 - System JS : WARNING resource://gre/modules/HealthReport.jsm:1037 - variable msg redeclares argument

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed this go by in my debug-build spew:
{
System JS : WARNING resource://gre/modules/HealthReport.jsm:1037 - variable msg redeclares argument
}

This is from this code (in a file that's unified into HealthReport.jsm):
> 530   _recordProviderError: function (name, msg, ex) {
> 531     let msg = "Provider error: " + name + ": " + msg;

http://mxr.mozilla.org/mozilla-central/source/services/metrics/providermanager.jsm#531

I think we can just drop the "let" there.

Marking as blocking bug 845431, since that's what added this chunk of code.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> Marking as blocking bug 845431, since that's what added this chunk of code.

er, "Marking as depending on"

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Dropping "let".

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d044c5d7c92

Comment 4

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/8d044c5d7c92