1049063 - reflow on zoom is broken (again)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

If you enable reflow on zoom from settings -> display -> reflow text, when you double tap on text needing reflow your screen just kinda dances around and never zooms in. To enhance the effect, you can also select the extra large text size.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Karen, do we care?

Comment 2

[Karen Rudnitski [:kar]]

Just so I understand. 

Does this happen ALWAYS when you enable reflow on zoom from the settings menu?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

yes

Comment 4

[Karen Rudnitski [:kar]]

Huh. I'm using my ol' faithful www.ottawaathleticclub.com website. And I see what you mean.

How about this for another dumb question. If 'double tap to zoom' is enabled as default (preffed on), does it work ok? Then it would only break if someone unchecked the box and checked it again?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Where do you see "double tap to zoom"? Reflow zoom is broken if you enable it ("reflow text" pref under settings->display) and otherwise the app works fine.

Comment 6

[Karen Rudnitski [:kar]]

I have two apologies here. First, it looks like my comment late last week didn't come through. 

Second, I must be daft. When I enable 'reflow test' from the settings -> display menu, you're right - nothing happens. So here's my daft question. Why would we include it in the product if nothing happens?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

We're going to consider removing this feature altogether.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Karen Rudnitski [:kar] from comment #6)
> I have two apologies here. First, it looks like my comment late last week
> didn't come through. 
> 
> Second, I must be daft. When I enable 'reflow test' from the settings ->
> display menu, you're right - nothing happens. So here's my daft question.
> Why would we include it in the product if nothing happens?

That's the question. It's broken now, but I don't think the feature is useful anymore with the modern mobile web. I'm recommending that we just disable the feature and remove the code rather than fix it.

Comment 9

[Karen Rudnitski [:kar]]

ah ha. We got there in the end. And we discussed this at last week's triage while you were enjoying PTO and came up with pretty much the same conclusion. I think this was useful a year ago, but I think now that the mobile web has moved on some, this feature's benefit does not outweigh the work required to get this fixed. Therefore I think we're all on the same page - let's remove this code.

Comment 10

[Aaron Train [:aaronmt]]

> Therefore I think we're all on the same page - let's remove this code.

Should open a new bug to detail what would involved with this.

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

submitted bug 1059014 for the removal of code