Closed
Bug 1049072
Opened 10 years ago
Closed 3 years ago
nsNameSpaceManager doesn't need virtual methods
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
95 Branch
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: mccr8)
References
Details
Attachments
(1 file)
they don't over ride anything, and I can't see a reason you'd want to sub class it, so these methods might as well not be virtual.
Comment 1•10 years ago
|
||
Something something outside-libxul-callers? Not sure if that's still relevant in this day and age.
Comment 2•10 years ago
|
||
(In reply to :Ms2ger from comment #1) > Something something outside-libxul-callers? Not sure if that's still > relevant in this day and age. Hm, we do export it. Boo. Well, MOZ_FINAL it and see who complains?
OS: Linux → All
Hardware: x86_64 → All
Comment 3•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046 Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5. If you have questions, please contact :mdaly.
Priority: -- → P5
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Assignee | ||
Comment 4•3 years ago
|
||
I came across this bug when I accidentally searched for sNameSpaceManager in Bugzilla instead of SearchFox. It looks like qDot dealt with most of the de-COM-ing in bug 455595, but there are still two virtual methods that I guess got overlooked. Maybe the third time will be the charm for deCOMtaminating nsNameSpaceManager.
Assignee: nobody → continuation
Depends on: 455595
Assignee | ||
Comment 5•3 years ago
|
||
This is ancient residue from when this class was nsISupports.
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7822d0f6f9fc nsNameSpaceManager doesn't need virtual methods. r=peterv
Comment 7•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•