1049072 - nsNameSpaceManager doesn't need virtual methods

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Trevor Saunders (:tbsaunde)]

they don't over ride anything, and I can't see a reason you'd want to sub class it, so these methods might as well not be virtual.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Something something outside-libxul-callers? Not sure if that's still relevant in this day and age.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to :Ms2ger from comment #1)
> Something something outside-libxul-callers? Not sure if that's still
> relevant in this day and age.

Hm, we do export it.  Boo.  Well, MOZ_FINAL it and see who complains?

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

I came across this bug when I accidentally searched for sNameSpaceManager in Bugzilla instead of SearchFox. It looks like qDot dealt with most of the de-COM-ing in bug 455595, but there are still two virtual methods that I guess got overlooked. Maybe the third time will be the charm for deCOMtaminating nsNameSpaceManager.

Comment 5

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1049072 - nsNameSpaceManager doesn't need virtual methods.

This is ancient residue from when this class was nsISupports.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7822d0f6f9fc
nsNameSpaceManager doesn't need virtual methods. r=peterv

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7822d0f6f9fc