Closed Bug 1049085 Opened 6 years ago Closed 6 years ago

Robocop SUITE-START message wrong when TEST_PATH is set

Categories

(Testing :: Mochitest, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox33 fixed, firefox34 fixed)

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: gbrown, Assigned: akachkach)

References

Details

Attachments

(1 file, 1 obsolete file)

This is not a big deal, but a little disconcerting, when running a single robocop test locally:

gbrown@mozpad:~/objdirs/droid$ export TEST_PATH=testNewTab
gbrown@mozpad:~/objdirs/droid$ make mochitest-robocop
0 INFO Device info: {}
1 INFO Test root: /sdcard/tests
2 INFO Android sdk version '12'; will use this to filter manifests
3 INFO SUITE-START | Running 61 tests
pk12util: PKCS12 IMPORT SUCCESSFUL
...
This is a little odd on tbpl too, presumably because of chunking?

https://tbpl.mozilla.org/php/getParsedLog.php?id=45256473&tree=Mozilla-Central&full=1

09:43:30     INFO -  3 INFO SUITE-START | Running 61 tests
09:43:30     INFO -  4 INFO Running tests 1-16/61

https://tbpl.mozilla.org/php/getParsedLog.php?id=45257118&tree=Mozilla-Central&full=1

10:00:10     INFO -  3 INFO SUITE-START | Running 61 tests
10:00:10     INFO -  4 INFO Running tests 17-32/61
This seems to be because of some ulterior filtering done to the robocop tests:

http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#683

I'll try a quick fix for this.
Assignee: nobody → akachkach
Blocks: 1034267
Status: NEW → ASSIGNED
Comment on attachment 8468004 [details] [diff] [review]
0001-Bug-1049085-Correct-list-of-tests-for-the-robocop-su.patch

Review of attachment 8468004 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtestsremote.py
@@ +675,5 @@
>              dm._checkCmd(["install", "-r", options.robocopApk])
>  
> +        active_tests = [t['name'] for t in robocop_tests if not (options.testPath and options.testPath != t['name']) and
> +                                                            t['name'] in my_tests and
> +                                                            'disabled' in t]

this really should be formatted easier.  While it is understandable we have 4 conditions we are checking for and we should either simplify that list or make this a for loop.
Attachment #8468004 - Flags: review?(jmaher) → review-
Updated patch.

Try run here: https://tbpl.mozilla.org/?tree=Try&rev=37145f5b7895
(could you confirm the numbers shown make sense?)
Attachment #8468004 - Attachment is obsolete: true
Attachment #8468732 - Flags: review?(jmaher)
Comment on attachment 8468732 [details] [diff] [review]
0001-Bug-1049085-Correct-list-of-tests-for-the-robocop-su.patch

Review of attachment 8468732 [details] [diff] [review]:
-----------------------------------------------------------------

much better.
Attachment #8468732 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3e86e8d97314
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.