Closed Bug 1049312 Opened 11 years ago Closed 11 years ago

Fix warnings in toolkit/loader.js

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: poiru, Assigned: poiru)

References

Details

Attachments

(1 file)

PR #1572
46 bytes, text/x-github-pull-request
evold
: review+
Details | Review
System JS : WARNING resource://gre/modules/commonjs/toolkit/loader.js:410 - test for equality (==) mistyped as assignment (=)? System JS : WARNING resource://gre/modules/commonjs/toolkit/loader.js:412 - test for equality (==) mistyped as assignment (=)? System JS : WARNING resource://gre/modules/commonjs/toolkit/loader.js:419 - test for equality (==) mistyped as assignment (=)? System JS : WARNING resource://gre/modules/commonjs/toolkit/loader.js:421 - test for equality (==) mistyped as assignment (=)? System JS : WARNING resource://gre/modules/commonjs/toolkit/loader.js:462 - test for equality (==) mistyped as assignment (=)? System JS : WARNING resource://gre/modules/commonjs/toolkit/loader.js:870 - anonymous function does not always return a value System JS : WARNING resource://gre/modules/commonjs/toolkit/loader.js:860 - function findAllModuleIncludes does not always return a value
Attached file PR #1572 —
Attachment #8468223 - Flags: review?(evold)
Priority: -- → P2
Attachment #8468223 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/0c0d67a0bc107677250482978d3950b13e7cd10f Bug 1049312 - Fix 'test for equality (==) mistyped as assignment (=)' warnings in loader.js https://github.com/mozilla/addon-sdk/commit/b2dc0300c2dbda3b2f7fe2773e5615113c4171cf Bug 1049312 - Fix 'function does not always return a value' warnings in loader.js https://github.com/mozilla/addon-sdk/commit/68979d8eac30236e7407f8fcdb6cb7a0777f870c Merge pull request #1572 from poiru/fix-loader-warn Bug 1049312 - Fix warnings in toolkit/loader.js r=@erikvold
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: