New WindowsDllBlocklist.cpp compilation failure on mingw (Firefox 31)

NEW
Unassigned

Status

()

Core
mozglue
4 years ago
4 years ago

People

(Reporter: Georg Koppen, Unassigned)

Tracking

31 Branch
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
While preparing Tor Browser for the switch to ESR 31 I ran into the following compilation error:

/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp: In static member function 'static void {anonymous}::DllBlockSet::Write(HANDLE)':
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:422:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (b->mVersion != -1) {
                           ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp: In function 'NTSTATUS {anonymous}::patched_LdrLoadDll(PWCHAR, PULONG, PUNICODE_STRING, PHANDLE)':
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:645:1: error: jump to label 'continue_loading' [-fpermissive]
 continue_loading:
 ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:538:12: error:   from here [-fpermissive]
       goto continue_loading;
            ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:556:10: error:   crosses initialization of 'char* dot'
   char * dot = strchr(dllName, '.');
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:645:1: error: jump to label 'continue_loading' [-fpermissive]
 continue_loading:
 ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:528:10: error:   from here [-fpermissive]
     goto continue_loading;
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:556:10: error:   crosses initialization of 'char* dot'
   char * dot = strchr(dllName, '.');
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:645:1: error: jump to label 'continue_loading' [-fpermissive]
 continue_loading:
 ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:506:10: error:   from here [-fpermissive]
     goto continue_loading;
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:556:10: error:   crosses initialization of 'char* dot'
   char * dot = strchr(dllName, '.');
          ^
(Reporter)

Comment 1

4 years ago
Not sure if that is a new instance of bug 584680.
(Reporter)

Comment 2

4 years ago
Seems to be caused by the fix for bug 973138: That one got uplifted but the mingw fix for the bug introduced by it (https://hg.mozilla.org/mozilla-central/rev/fa9b99291387) not.
(Reporter)

Updated

4 years ago
Summary: New nsWindowsDllBlocklist.cpp compilation failure on mingw (Firefox 31) → New WindowsDllBlocklist.cpp compilation failure on mingw (Firefox 31)
You need to log in before you can comment on or make changes to this bug.