1049366 - New WindowsDllBlocklist.cpp compilation failure on mingw (Firefox 31)

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Georg Koppen]

While preparing Tor Browser for the switch to ESR 31 I ran into the following compilation error:

/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp: In static member function 'static void {anonymous}::DllBlockSet::Write(HANDLE)':
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:422:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (b->mVersion != -1) {
                           ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp: In function 'NTSTATUS {anonymous}::patched_LdrLoadDll(PWCHAR, PULONG, PUNICODE_STRING, PHANDLE)':
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:645:1: error: jump to label 'continue_loading' [-fpermissive]
 continue_loading:
 ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:538:12: error:   from here [-fpermissive]
       goto continue_loading;
            ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:556:10: error:   crosses initialization of 'char* dot'
   char * dot = strchr(dllName, '.');
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:645:1: error: jump to label 'continue_loading' [-fpermissive]
 continue_loading:
 ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:528:10: error:   from here [-fpermissive]
     goto continue_loading;
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:556:10: error:   crosses initialization of 'char* dot'
   char * dot = strchr(dllName, '.');
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:645:1: error: jump to label 'continue_loading' [-fpermissive]
 continue_loading:
 ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:506:10: error:   from here [-fpermissive]
     goto continue_loading;
          ^
/home/ubuntu/build/tor-browser/mozglue/build/WindowsDllBlocklist.cpp:556:10: error:   crosses initialization of 'char* dot'
   char * dot = strchr(dllName, '.');
          ^

Comment 1

[Georg Koppen]

Not sure if that is a new instance of bug 584680.

Comment 2

[Georg Koppen]

Seems to be caused by the fix for bug 973138: That one got uplifted but the mingw fix for the bug introduced by it (https://hg.mozilla.org/mozilla-central/rev/fa9b99291387) not.

Comment 3

[Mike Hommey [:glandium]]

Considering Tom has done some successful mingw builds of recent m-c, I'll assume this was fixed somewhen in the past 4 years.