104938 - CRASH: Routing Recipient causes MS Word to crash.

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect)

Description

[Trix Supremo]

With Netscape Mail as the default, in MS Word if you select "Routing Recipient"
instead of "Mail Recipient(as Attachment)...", an application error will occur.

DIRECTIONS:
1. Set Netscape Mail to be your default email client.
2. Open MS Word(don't need to enter anything into the document)
3. Select File|Send To|Routing Recipient

ACTUAL RESULTS:
An application error occurs causing MS Word to crash.

EXPECTED RESULTS:
With Outlook Express as the default, the Routing Slip dialog is displayed.

With Communicator 4.x as the default, a "General mail failure.  Close Microsoft
Word, restart the mail system, and try again." which is an error dialog from MS
Word.

At least with 4.x, we exit gracefully.

Comment 1

[Trix Supremo]

Just an additional note.  This is not isolated to just MS Word, but Excel
displays the same problem.  On Powerpoint though, it exits gracefully with an
error dialog "Powerpoint found an error and it can't correct...", exiting the
app does allow you to save the doc and exit.

Comment 2

[Krishna Mohan]

Attachment: fix for the crash problem.

Comment 3

[Krishna Mohan]

The problem is with returning SUCCESS_SUCCESS instead of MAPI_E_FAILURE for
unsupported functionalities in this release.   There is no need to return
MAPI_E_FAILURE from the functions those do not have OUT parameter, still I feel
it is better to let the app. know about it.

Rajiv  - Can you please review
mscott - Can you please super review the same

Thanks

Comment 4

[Krishna Mohan]

Forgot to CC Rajiv (Reviewer)

Comment 5

[Krishna Mohan]

Attachment: New patch with more context

Comment 6

[Rajiv Dayal]

good, this patch is easier to review.

r=rdayal.

Since this could help in removing probable crashes when calls are made to
non-implemented Simple MAPI functions by the mapi apps, am nominating this for 
094 branch. A simple no brainer kinda change/fix.

Comment 7

[lchiang]

What does the user see with this patch for these unsupported items?

Comment 8

[Rajiv Dayal]

MAPI is a set of APIs which returns error codes, what the user sees is completly
based on what the MAPI apps displays to the user when they get these return codes. 

Comment 9

[Scott MacGregor]

Comment on attachment 53678 [details] [diff] [review]
New patch with more context

sr=mscott. Not really much for me to review here. I'm assuming with these changes our 4 basic mapi clients still work....

Comment 10

[Jaime Rodriguez, Jr.]

pls get this in tonight = PDT+

Comment 11

[lchiang]

This wasn't checked in last night?  

Comment 12

[Tiantian Kong]

Will be checked in today.

Comment 13

[Jaime Rodriguez, Jr.]

hmmmm ... we didn't check this in last night?

Comment 14

[Srilatha Moturi]

Checked into 0.9.4 branch

Comment 15

[Tiantian Kong]

Trix:

Please verify this bug on tomorrow's build ASAP. Many thanks.

Comment 16

[Trix Supremo]

verified on 2001-10-17-05-0.9.4

General Mail Failure warning dialog is now displayed instead of crashing which
is the same behavior as Comm. 4.x.