Closed
Bug 1049477
Opened 11 years ago
Closed 11 years ago
Remove logic from test_lockscreen_unlock_to_emergency_call_screen.py
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: garndt)
Details
Attachments
(1 file)
In this commit a dev added logic to skip part of the test based on Gaia attributes.
https://github.com/mozilla-b2g/gaia/commit/ea45b90fd0dd551d0decdc3e9cc38168ff30185d
Logic like this can cause false positives, eg if Gaia's mobile connection is broken on device then this test would pass.
We should configure the test to run in the manifest.ini file and remove this logic.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → garndt
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8470483 -
Flags: review?(zcampbell)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8470483 [details] [review]
Github PR #22685
r+ that's great.
Attachment #8470483 -
Flags: review?(zcampbell) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Oh one more thing, we need to squash/rebase the two commits into one before we merge them. Just retain the first commit's message and that's fine.
|
|
Reporter | |
Comment 4•11 years ago
|
||
Just a ni? to remind you to follow up on the squash.
Flags: needinfo?(garndt)
|
|
Reporter | |
Comment 6•11 years ago
|
||
Looks great, merged:
https://github.com/mozilla-b2g/gaia/commit/acead54e798dcc436433fc359dda3a1409c5a44a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•