1049522 - Check / add / document throttling across all our APIs

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Mathieu Pillard [:mat]]

We document that the app submission API is throttled to 10 requests/day, but I can't find it in the code. Amusingly, we also have the opposite problem: the feedback and abuse APIs are throttled, but we don't document this. 

There are also a couple endpoints where we probably should have throttling but we haven't, like the rating API, and maybe a couple others, so let's do a check for all the APIs we have.

Comment 1

[Mathieu Pillard [:mat]]

Oh, and we have a API_THROTTLE setting, but it doesn't appear to be used.

Comment 2

[Ram Dayal Vaishnav [:ram]]

Hi Andy/MP-Team, it looks like this might not be very much clear to the newbie how to fix this. Can you put some information here for newbies so that they can pick this bug and fix it. You could specifically provide information like 'where and how to add THROTTLE?'

Thanks,
Ram

Comment 3

[Andy McKay]

Marketplace uses the django rest framework, perhaps that's a good place to start?

http://www.django-rest-framework.org/api-guide/throttling/

Comment 4

[y13uc234]

I would like to work on it

Comment 5

[Ram Dayal Vaishnav [:ram]]

Sure, assigning you to the bug. Let us know if you face any issues here.

Comment 6

[Ram Dayal Vaishnav [:ram]]

y13uc234 looks like the team did not find it as a good first bug, you can keep continue to work on this or feel free to pick other good first bugs.