1049565 - The 'Back' button is grayed out after selecting the 'sad' icon

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Perform a 1:1 call
2. End the call
3. Click on the 'sad' icon to provide feedback
4. Look at the 'Back' button on the top

Actual results:
'Back" button is grayed out, but functional

Comment 1

[Paul Silaghi, QA [:pauly]]

Attachment: loop - back button grayed out.png

Comment 2

[Maire Reavy [:mreavy]]

Looks to be a regression from landing bug 972992

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

This matches :darrin's design https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#feedback

Comment 4

[Mark Banner (:standard8)]

Yep, lets get Darrin's feedback here.

Comment 5

[Darrin Henein [:darrin]]

Agreed -- I thought it looked OK in my spec but seeing it here it needs to be darker. Lets make the border #AAA and the text #777.

Also the button background should match the panel background, essentially being transparent.

Comment 6

[Andrei Oprea [mention me on [e-mail]]]

Attachment: Update style for feedback form back button

Comment 7

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8486221 [details] [diff] [review]
Update style for feedback form back button

Review of attachment 8486221 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :)

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/51cabe253d11

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/51cabe253d11

Comment 10

[Paul Silaghi, QA [:pauly]]

Verified fixed 35.0a1 (2014-09-10) Win 7, OS X 10.9.5, Ubuntu 12.10

Comment 11

[u279076]

Paul can you please test this again across platforms using the following Try-server build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f9eb2cbac352

Comment 12

[Paul Silaghi, QA [:pauly]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #11)
> Paul can you please test this again across platforms using the following
> Try-server build?
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-
> f9eb2cbac352
Verified fixed Win 7, OS X 10.9.5, Ubuntu 13.04

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8486221 [details] [diff] [review]
Update style for feedback form back button

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/133f509408d6

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8486221 [details] [diff] [review]
Update style for feedback form back button

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.

Comment 16

[u279076]

Paul, can you please verify this in Aurora now that it's been uplifted?

Comment 17

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 OS X 10.9.5