Closed
Bug 1049565
Opened 10 years ago
Closed 10 years ago
The 'Back' button is grayed out after selecting the 'sad' icon
Categories
(Hello (Loop) :: Client, defect, P1)
Tracking
(firefox34 verified, firefox35 verified)
VERIFIED
FIXED
mozilla35
People
(Reporter: pauly, Assigned: aoprea)
References
Details
(Whiteboard: [regression][loop-uplift][fig:verified])
Attachments
(2 files)
20.38 KB,
image/png
|
Details | |
3.01 KB,
patch
|
NiKo
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR: 1. Perform a 1:1 call 2. End the call 3. Click on the 'sad' icon to provide feedback 4. Look at the 'Back' button on the top Actual results: 'Back" button is grayed out, but functional
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Looks to be a regression from landing bug 972992
Priority: -- → P1
Whiteboard: [regression]
Target Milestone: --- → mozilla34
This matches :darrin's design https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#feedback
Comment 5•10 years ago
|
||
Agreed -- I thought it looked OK in my spec but seeing it here it needs to be darker. Lets make the border #AAA and the text #777. Also the button background should match the panel background, essentially being transparent.
Flags: needinfo?(dhenein)
Assignee | ||
Updated•10 years ago
|
QA Contact: aoprea
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aoprea
QA Contact: aoprea
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8486221 -
Flags: review?(nperriault)
Comment on attachment 8486221 [details] [diff] [review] Update style for feedback form back button Review of attachment 8486221 [details] [diff] [review]: ----------------------------------------------------------------- Looks good :)
Attachment #8486221 -
Flags: review?(nperriault) → review+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/51cabe253d11
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: mozilla34 → mozilla35
Reporter | ||
Comment 10•10 years ago
|
||
Verified fixed 35.0a1 (2014-09-10) Win 7, OS X 10.9.5, Ubuntu 12.10
Status: RESOLVED → VERIFIED
status-firefox35:
--- → verified
Updated•10 years ago
|
Whiteboard: [regression] → [regression][loop-uplift]
Comment 11•10 years ago
|
||
Paul can you please test this again across platforms using the following Try-server build? http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rjesup@wgate.com-f9eb2cbac352
Flags: needinfo?(paul.silaghi)
QA Contact: paul.silaghi
Whiteboard: [regression][loop-uplift] → [regression][loop-uplift][fig:verifyme]
Reporter | ||
Comment 12•10 years ago
|
||
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #11) > Paul can you please test this again across platforms using the following > Try-server build? > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rjesup@wgate.com- > f9eb2cbac352 Verified fixed Win 7, OS X 10.9.5, Ubuntu 13.04
Flags: needinfo?(paul.silaghi)
Whiteboard: [regression][loop-uplift][fig:verifyme] → [regression][loop-uplift][fig:verified]
Comment 13•10 years ago
|
||
Comment on attachment 8486221 [details] [diff] [review] Update style for feedback form back button Approval Request Comment Uplift request for patches staged and tested on Fig
Attachment #8486221 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox34:
--- → fixed
Comment 15•10 years ago
|
||
Comment on attachment 8486221 [details] [diff] [review] Update style for feedback form back button I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8486221 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 16•10 years ago
|
||
Paul, can you please verify this in Aurora now that it's been uplifted?
Flags: needinfo?(paul.silaghi)
Reporter | ||
Comment 17•10 years ago
|
||
Verified fixed FF 34b1 OS X 10.9.5
Flags: needinfo?(paul.silaghi)
You need to log in
before you can comment on or make changes to this bug.
Description
•