Closed Bug 1049593 Opened 5 years ago Closed 5 years ago

Make BaseRect::Contains(point) behave correctly for non-integer points

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Right now BaseRect::Contains(point) converts the point to a unit rectangle. This is presumably because for integer rectangles we want to treat the right/bottom edge as not hit so pixel calculations work well. It completely screws things up for other use cases though, particularly if the rect is a float based rect.
Attached patch possible patchSplinter Review
Perhaps this.
Attachment #8468494 - Flags: review?(bas)
Comment on attachment 8468494 [details] [diff] [review]
possible patch

Review of attachment 8468494 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with this if it passes tests.
Attachment #8468494 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/8be5d8233990
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.