Closed
Bug 1049593
Opened 10 years ago
Closed 10 years ago
Make BaseRect::Contains(point) behave correctly for non-integer points
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
Right now BaseRect::Contains(point) converts the point to a unit rectangle. This is presumably because for integer rectangles we want to treat the right/bottom edge as not hit so pixel calculations work well. It completely screws things up for other use cases though, particularly if the rect is a float based rect.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8468494 [details] [diff] [review] possible patch Review of attachment 8468494 [details] [diff] [review]: ----------------------------------------------------------------- I'm fine with this if it passes tests.
Attachment #8468494 -
Flags: review?(bas) → review+
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8be5d8233990
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8be5d8233990
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•