If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

The compositor should not crash if applying a mask layer fails

VERIFIED FIXED in Firefox 34

Status

()

Core
Graphics: Layers
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: nical, Assigned: nical)

Tracking

({topcrash})

unspecified
mozilla34
topcrash
Points:
---

Firefox Tracking Flags

(firefox34 verified)

Details

(crash signature)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This is a followup from bug 1043426 where the patch got reviewed (but bounced on inbound)

try push with the patch fixed: https://tbpl.mozilla.org/?tree=Try&rev=ebc58d4d57dd
(Assignee)

Comment 1

3 years ago
Created attachment 8468504 [details] [diff] [review]
Don't crash when failing to apply a mask (carry r=bas)
Assignee: nobody → nical.bugzilla
Crash Signature: [@mozilla::layers::CompositorD3D11::DrawQuad(mozilla::gfx::RectTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::RectTyped<mozilla::gfx::UnknownUnits> const&, mozilla::layers::EffectChain const&, float, mozilla::gfx::Matrix4x4 const&)]
QA Whiteboard: [qa+]
Keywords: topcrash
status-firefox34: --- → affected
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bc9fd5d0476
This may be affecting the high number of crashes still on Nightly that seem to be related to bug 1043426.
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/mozilla-central/rev/0bc9fd5d0476

my bad I put the wrong bug # in the commit.

This bug is closed now.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
status-firefox34: affected → fixed
Target Milestone: --- → mozilla34
Noting I can't verify this yet as this is still a top crashing signature on Nightly. 

Reports from last 3 days: https://crash-stats.mozilla.com/report/list?signature=mozilla%3A%3Alayers%3A%3ACompositorD3D11%3A%3ADrawQuad%28mozilla%3A%3Agfx%3A%3ARectTyped%3Cmozilla%3A%3Agfx%3A%3AUnknownUnits%3E+const%26%2C+mozilla%3A%3Agfx%3A%3ARectTyped%3Cmozilla%3A%3Agfx%3A%3AUnknownUnits%3E+const%26%2C+mozilla%3A%3Alayers%3A%3AEffectChain+const%26%2C+float%2C+mozilla%3A%3Agfx%3A%3AMatrix4x4+const%26%29&product=Firefox&query_type=contains&range_unit=days&process_type=any&version=Firefox%3A34.0a1&hang_type=any&date=2014-08-18+17%3A00%3A00&range_value=3#tab-table
No crashes past 2014081703. Verifying based on crash-stats.
Status: RESOLVED → VERIFIED
status-firefox34: fixed → verified
You need to log in before you can comment on or make changes to this bug.