1049685 - [Tarako][Settings] Ringer's name overlay Alerts in Sound setting page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Ringer's name overlay Alerts

After ring tone is set from music, Ringer's name overlay Alerts in Sound setting page.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Hi Evelyn, could you help on this bug? Thanks!

Comment 2

[Evelyn Hung]

Yi-fan can help. :)

Comment 3

[yifan [:yifan][:yliao]]

Attachment: pull request

Bring text-overflow: ellipsis back and still keep box-shadow hack.
Use text-indent instead of left padding and '...   ' instead of ellipsis.
Only for li button.

Comment 4

[yifan [:yifan][:yliao]]

Attachment: too_long.png

Fixed result.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8469775 [details] [review]
pull request

Looks good to me, thanks! However, per https://bugzilla.mozilla.org/show_bug.cgi?id=1010675#c80 this should be a platform bug. Based on the decision there, I think we could land this to the tarako branch but not master.

Comment 6

[yifan [:yifan][:yliao]]

Merged into v1.3t
https://github.com/mozilla-b2g/gaia/pull/22652

Thank you. So according to bug 1010675, this PR might need to be backout once the behavior changes in gecko for v1.3t.

Comment 7

[Wayne Chang [:wchang]]

align flag to status

Comment 8

[Ryan VanderMeulen (PTO, back July 27)]

Does this affect any other branches?

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Correcting flag to 1.3T+

Comment 10

[Evelyn Hung]

(In reply to Arthur Chen [:arthurcc] from comment #5)
> Comment on attachment 8469775 [details] [review]
> pull request
> 
> Looks good to me, thanks! However, per
> https://bugzilla.mozilla.org/show_bug.cgi?id=1010675#c80 this should be a
> platform bug. Based on the decision there, I think we could land this to the
> tarako branch but not master.

Hi Arthur,
Is it a valid issue for master? If so, can we uplift this patch to 1.4/2.0/master and remove the master one once Gecko bug landed?

(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #6)
> Thank you. So according to bug 1010675, this PR might need to be backout
> once the behavior changes in gecko for v1.3t.

@Yi-fan, Gecko for 1.3t should not have any change, so we always need your patch for 1.3t.

Comment 11

[yifan [:yifan][:yliao]]

Got it.

There are some style conflicts in the shared/style/button.css between master and v1.3t when applying this patch. If the decision is we need this workaround for the master, I'll make another one.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

As there seems no progress in bug 1010675, let's land the workaround to the other branches and add a comment describing that the workaround should be removed once 1010675 gets fixed.

Comment 13

[yifan [:yifan][:yliao]]

Attachment: pull request for master branch

This PR is the workaround for master branch.

Comment 14

[yifan [:yifan][:yliao]]

Comment on attachment 8469775 [details] [review]
pull request

Please land this workaround on v1.4, thank you.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1049685
[User impact] if declined: Button text overlaps other UI elements in settings app when button text is too long
[Testing completed]: https://tbpl.mozilla.org/?rev=0d290adba539a1186c13610584224ec0aa138249&tree=Gaia-Try
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: N/A

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8472110 [details] [review]
pull request for master branch

r=me, thank you!

Comment 16

[yifan [:yifan][:yliao]]

Merged into master
https://github.com/mozilla-b2g/gaia/pull/22818

TBPL
https://tbpl.mozilla.org/?rev=e6ff9dd1f8c05eda816507bab3ad602c7e936b93&tree=Gaia-Try

Comment 17

[yifan [:yifan][:yliao]]

(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #16)
> Merged into master
> https://github.com/mozilla-b2g/gaia/pull/22818
> 
> TBPL
> https://tbpl.mozilla.org/
> ?rev=e6ff9dd1f8c05eda816507bab3ad602c7e936b93&tree=Gaia-Try

Backout Commit: c4ba26551979b0293fd168bfcc30d07a5efeed70 [c4ba265]
Found glitches in FTU Date & Time settings.

Comment 18

[yifan [:yifan][:yliao]]

Attachment: pull request for master & 2.0 branch, fixed FTU glitch

Add css selector :not(.change) to exclude 'change' buttons in FTU. To prevent unnecessary ellipsis.

Comment 19

[yifan [:yifan][:yliao]]

(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #6)
> Merged into v1.3t
> https://github.com/mozilla-b2g/gaia/pull/22652
> 
> Thank you. So according to bug 1010675, this PR might need to be backout
> once the behavior changes in gecko for v1.3t.

Backout Commit: 7539f4e52863521efa5acb9f4b285a05f44ee1ac [7539f4e]
Found glitches in FTU Date & Time settings.

Comment 20

[yifan [:yifan][:yliao]]

Attachment: pull request for 1.3t & 1.4 branch, fixed FTU glitch

Revised css to exclude 'change' button ellipsis in date & time settings in FTU.

Comment 21

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8474421 [details] [review]
pull request for master & 2.0 branch, fixed FTU glitch

Flagging Arnau as the patch involves other selectors.

Comment 22

[howie [:howie]]

Hi Arnau, can you help on the patch review? Thank you.

Comment 23

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Hey, Sorry it took me so long to look into this, I was on PTO.
In bug 1036147 we allowed multiline for list buttons.
The patched proposed here suggest going back to one line again, which would cause again localization issues like https://bug1036147.bugzilla.mozilla.org/attachment.cgi?id=8452719

I don't have a Tarako to test, but I guess this issue is not happening after landing bug 1036147, right?
My approach would be allowing multiline in previous releases as we now have in master.

I will take a closer look to 1.3

Comment 24

[howie [:howie]]

qawanted, please help to verify if this happens on Flame in 2.1, 2.0 and 1.4? If no, we should close this one since tarako is using 1.3T and it's fixed. Thanks.

Comment 25

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to howie [:howie] from comment #24)
> qawanted, please help to verify if this happens on Flame in 2.1, 2.0 and
> 1.4? If no, we should close this one since tarako is using 1.3T and it's
> fixed. Thanks.

Issue is NOT reproducible on Flame KK base only (v1.4), Flame 2.0, and Flame 2.1. Ringtone name properly displays without overlapping.

Tested on:

(Unable to pull correct environmental variables for Flame KK base)

Device: Flame
BuildID: 20140911220254
Gaia: 91dd0e596aa7c124dd968e1474b23e7992dc35a1
Gecko: a66168598533
Version: 32.0 (2.0)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame
BuildID: 20140912081053
Gaia: 59e5c2467b7b8219ed194a0d0a94c6ed59af95be
Gecko: b09d2857b74e
Version: 34.0a2 (2.1)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Comment 26

[Joshua Mitchell (Inactive)]

Testing the 2.0 and 2.1 branches in KK base is fine but 1.4 will be built on JB so we need to test 1.4 there.

QA-Wanted to test 1.4 on JB

Comment 27

[Duane Dixon [:ddixon]]

Attachment: 1.4_v123_screenshot.png

Comment 28

[Duane Dixon [:ddixon]]

Issue DOES occur in latest 1.4 Flame on the v123 base image (Jelly Bean). 

See attachment: '1.4_v123_screenshot.png'

Environmental Variables:

Device: Flame 1.4
BuildID: 20140910070823
Gaia: 6018a1c18f0c3eab25aac2ba3064904740591dd2
Gecko: 39c9dbc311f7
Version: 30.0 (1.4) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 29

[Joshua Mitchell (Inactive)]

(In reply to howie [:howie] from comment #24)
> qawanted, please help to verify if this happens on Flame in 2.1, 2.0 and
> 1.4? If no, we should close this one since tarako is using 1.3T and it's
> fixed. Thanks.

1.4 (JB) = Repro
2.0 (KK) = No Repro
2.1 (KK) = No Repro

Comment 30

[howie [:howie]]

per offline discussion with Wayne, 1.4 JB can be ignored. Thanks everyone for the help!