Uninstaller code needs to broadcast message that default mail/browser client has been changed/reset.

VERIFIED FIXED in mozilla0.9.9

Status

SeaMonkey
Installer
--
major
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Sean Su, Assigned: Sean Su)

Tracking

Trunk
mozilla0.9.9
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

1.79 KB, patch
Curt Patrick (gone)
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
10.43 KB, patch
Curt Patrick (gone)
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

17 years ago
This bug is similar to bug 104943.

Under WinXP, when the uninstaller restores the previous Start Menu items (for 
either the browser or mail), they do not get updated appropriately.  They still 
show the menu items as if they were not changed.

To fix this, the uninstaller needs to call:
  ::SendMessage( HWND_BROADCAST, WM_SETTINGCHANGE, 0,
(LPARAM)"Software\\Clients\\StartMenuInternet" );
  ::SendMessage( HWND_BROADCAST, WM_SETTINGCHANGE, 0, 
(LPARAM)"Software\\Clients\\Mail" );

It should only call these functions when the uninstaller has modified their 
respective registry keys.

Updated

17 years ago
Status: NEW → ASSIGNED

Updated

16 years ago
Keywords: nsbeta1

Comment 1

16 years ago
over to sean
Assignee: curt → ssu
Status: ASSIGNED → NEW
(Assignee)

Comment 2

16 years ago
accepting.  trivial fix.
Status: NEW → ASSIGNED
(Assignee)

Comment 3

16 years ago
Created attachment 67320 [details] [diff] [review]
patch to ns tree
(Assignee)

Comment 4

16 years ago
Created attachment 67321 [details] [diff] [review]
patch to moz tree

Updated

16 years ago
Keywords: nsbeta1 → nsbeta1+, patch
Target Milestone: --- → mozilla0.9.9

Updated

16 years ago
Attachment #67321 - Flags: review+

Updated

16 years ago
Attachment #67320 - Flags: review+
Comment on attachment 67320 [details] [diff] [review]
patch to ns tree

sr=dveditz
Attachment #67320 - Flags: superreview+
Comment on attachment 67321 [details] [diff] [review]
patch to moz tree

>+  /* Broadcast message only under NT51 (WinXP) regarding the following
>+   * registry keys in case they were changed during uninstallation.  If they
>+   * were, then the broadcast will alert the OS to update the appropriate UIs.
>+   * This needs to be done regardless if the user canceled the uninstall
>+   * process or not.
>+   */
>+  if(ulOSType & OS_NT51)
>+  {
>+    SendMessage(HWND_BROADCAST, WM_SETTINGCHANGE, 0, (LPARAM)"Software\\Clients\\StartMenuInternet");
>+    SendMessage(HWND_BROADCAST, WM_SETTINGCHANGE, 0, (LPARAM)"Software\\Clients\\Mail");
>+  }

Why go to all the version checking work? Does it hurt anything to broadcast
all the time?

There would be no way to do this from an XPInstall script. Should I add
broadcasts for all registry changes just in case someone wants it?

sr=dveditz
Attachment #67321 - Flags: superreview+
Comment on attachment 67320 [details] [diff] [review]
patch to ns tree

>+;*** LOCALIZE ME BABY ***
>+ERROR_GETVERSION=GetVersionEx() failed!
> 

Don't you need this in the Moz tree uninstall.it too?
(Assignee)

Comment 8

16 years ago
I don't know if it hurts anything if the broadcast is done all the time.  I do
the OS version check because not all OS'es have the StartMenuInternet key.

As for exposing a 'Broadcast' type of function in xpinstall, I would rather we
have a generic function that just calls SendMessage().  This way we can send any
type of message we want (though it might be more complicated).

yes, I did forget to add the string to the mozilla's unisntall.it file.  Just
did it in my local tree.
(Assignee)

Comment 9

16 years ago
patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 10

16 years ago
nsbeta1+ issues for Win Installer

Comment 11

16 years ago
verified on XP trunk and branch
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.