104982 - Uninstaller code needs to broadcast message that default mail/browser client has been changed/reset.

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

This bug is similar to bug 104943.

Under WinXP, when the uninstaller restores the previous Start Menu items (for 
either the browser or mail), they do not get updated appropriately.  They still 
show the menu items as if they were not changed.

To fix this, the uninstaller needs to call:
  ::SendMessage( HWND_BROADCAST, WM_SETTINGCHANGE, 0,
(LPARAM)"Software\\Clients\\StartMenuInternet" );
  ::SendMessage( HWND_BROADCAST, WM_SETTINGCHANGE, 0, 
(LPARAM)"Software\\Clients\\Mail" );

It should only call these functions when the uninstaller has modified their 
respective registry keys.

Comment 1

[Syd Logan]

over to sean

Comment 2

[Sean Su]

accepting.  trivial fix.

Comment 3

[Sean Su]

Attachment: patch to ns tree

Comment 4

[Sean Su]

Attachment: patch to moz tree

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 67320 [details] [diff] [review]
patch to ns tree

sr=dveditz

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 67321 [details] [diff] [review]
patch to moz tree

>+  /* Broadcast message only under NT51 (WinXP) regarding the following
>+   * registry keys in case they were changed during uninstallation.  If they
>+   * were, then the broadcast will alert the OS to update the appropriate UIs.
>+   * This needs to be done regardless if the user canceled the uninstall
>+   * process or not.
>+   */
>+  if(ulOSType & OS_NT51)
>+  {
>+    SendMessage(HWND_BROADCAST, WM_SETTINGCHANGE, 0, (LPARAM)"Software\\Clients\\StartMenuInternet");
>+    SendMessage(HWND_BROADCAST, WM_SETTINGCHANGE, 0, (LPARAM)"Software\\Clients\\Mail");
>+  }

Why go to all the version checking work? Does it hurt anything to broadcast
all the time?

There would be no way to do this from an XPInstall script. Should I add
broadcasts for all registry changes just in case someone wants it?

sr=dveditz

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 67320 [details] [diff] [review]
patch to ns tree

>+;*** LOCALIZE ME BABY ***
>+ERROR_GETVERSION=GetVersionEx() failed!
> 

Don't you need this in the Moz tree uninstall.it too?

Comment 8

[Sean Su]

I don't know if it hurts anything if the broadcast is done all the time.  I do
the OS version check because not all OS'es have the StartMenuInternet key.

As for exposing a 'Broadcast' type of function in xpinstall, I would rather we
have a generic function that just calls SendMessage().  This way we can send any
type of message we want (though it might be more complicated).

yes, I did forget to add the string to the mozilla's unisntall.it file.  Just
did it in my local tree.

Comment 9

[Sean Su]

patch checked in.

Comment 10

[Grace Bush]

nsbeta1+ issues for Win Installer

Comment 11

[Grace Bush]

verified on XP trunk and branch