1049981 - Make error for non-existent files listed in SOURCES less ambiguous

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Biru [:poiru]]

"Reference to a file that doesn't exist in UNIFIED_SOURCES (Foo.cpp)" is quite easy to mistread.

Comment 1

[Biru [:poiru]]

Attachment: Make error for non-existent files listed in SOURCES less ambiguous

The new message is similar to the equivalent error for EXPORTS.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8468921 [details] [diff] [review]
Make error for non-existent files listed in SOURCES less ambiguous

Review of attachment 8468921 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +357,5 @@
>          for symbol in ('SOURCES', 'HOST_SOURCES', 'UNIFIED_SOURCES'):
>              for src in (sandbox[symbol] or []):
>                  if not os.path.exists(mozpath.join(sandbox['SRCDIR'], src)):
> +                    raise SandboxValidationError('File listed in %s does not '
> +                        'exist: %s' % (symbol, src), sandbox)

You could probably stand a set of quotes around the %s for the filename just for extra clarity.

Comment 3

[Biru [:poiru]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2334cddcd2c3

Comment 4

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/2334cddcd2c3