105005 - xprint Makefile doesn't do dependencies right

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The VPATH hackery in the gfx/src/xprint/Makefile.in doesn't do dependencies
right.  See the current orange on the comet tinderbox.

modules/zlib/standalone/Makefile.in probably does work right.

Comment 1

[hacker formerly known as [e-mail]]

Nope, standalone zlib doesn't get it correct either.  The problem is caused by a
descrepancy in what the build system sees as the name of the object file and
what gcc thinks that it should be.  If the name of the src file is foo.c, then
gcc -MD gives foo.o as the name of the rule in the .deps/foo.pp file.  We can
work around this by using the mkdepend rules instead of gcc -MD for those dirs. 

Comment 2

[hacker formerly known as [e-mail]]

Attachment: Turn off compiler dependencies when using non-default OBJ_SUFFIX

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

That seems like a messy solution, since compiler-generated dependencies
generally work very well.

One interesting thing I found is that cpp outputs the correct filename when I
pass  -MD to gcc but not when I use -Wp,-Md,file.pp.  So gcc is probably not
passing something to cpp when we use -Wp,-MD, but perhaps we could explicitly
pass it with -Wp...

Comment 4

[hacker formerly known as [e-mail]]

Attachment: Scrap the extra VPATH and use INSTALL to symlink srcfiles to avoid rebuilds

Comment 5

[Roland Mainz]

Is it really required to kill the VPATH ? ;-(

Comment 6

[hacker formerly known as [e-mail]]

At this point, yes.  gcc (<= 2.95.3) -MD doesn't give the proper dependency
target rule if you change the name of the output file to something other than
srcfile.o.  dbaron claims that gcc3 gets it right but we need to work
everywhere. And the mkdepend workaround was causing problems elsewhere.

Comment 7

[jag (Peter Annema)]

Comment on attachment 53885 [details] [diff] [review]
Scrap the extra VPATH and use INSTALL to symlink srcfiles to avoid rebuilds

r=jag

Comment 8

[hacker formerly known as [e-mail]]

Checked in.