Closed Bug 1050052 Opened 11 years ago Closed 11 years ago

Change Lockscreen & Homescreen background underlay darkness

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S2 (15aug)

People

(Reporter: mnjul, Assigned: mnjul)

Details

(Whiteboard: [p=1])

Attachments

(3 files)

shaded (current).png
204.92 KB, image/png
Details
unshaded (should-be).png
252.17 KB, image/png
padamczyk
: ui-review-
Details
Patch (PR @ GitHub)
46 bytes, text/x-github-pull-request
gweng
: review+
padamczyk
: ui-review+
Details | Review
After bug 1039631 lands the lockscreen is shaded with a uniform dark overlay. As bug 1039631 states that gradients should be abolished, let's remove the shaded overlay altogether, giving it the original unshaded look. Related: bug 950884 and bug 1020115.
Attached image shaded (current).png —
This is the current look.
This is the original look without the linear gradient on the top.
Comment on attachment 8468995 [details] unshaded (should-be).png Hi Patryk, Could you tell me if this "unshaded" version is what we should be having? Thanks.
Attachment #8468995 - Flags: ui-review?(padamczyk)
Attachment #8468995 - Flags: ui-review?(padamczyk) → ui-review-
We need a darker underlay so the time text doesn't disappear can you make sure both the home and lockscreen have a 5% black underlay.
Sorry typo... > can you make sure both the home and lockscreen have an 8% black underlay.
Summary: Lockscreen looks significantly darker than it should be → Change Lockscreen & Homescreen background underlay darkness
Attached file Patch (PR @ GitHub) —
Okies, 8% dark shade for lockscreen & homescreen. Does this patch look good? Thanks.
Attachment #8469856 - Flags: ui-review?(padamczyk)
Assignee: nobody → jlu
Whiteboard: [p=1]
Hey John, 8% looks good on the homescreen, its a bit too light on some of the wallpapers. Can we make it 10%? Thanks.
Hi Patryck, please see if 10% looks good on the device by checking out attachment 8469856 [details] [review] again. Thanks!
^NI Patryk (and sorry for typo on your name)
Flags: needinfo?(padamczyk)
NP! Looks good! Ship it.
Flags: needinfo?(padamczyk)
Attachment #8469856 - Flags: ui-review?(padamczyk) → ui-review-
Attachment #8469856 - Flags: ui-review- → ui-review+
Comment on attachment 8469856 [details] [review] Patch (PR @ GitHub) Hi Greg, Please help review this one-liner CSS patch. Thanks!
Attachment #8469856 - Flags: review?(gweng)
Attachment #8469856 - Flags: review?(gweng) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/a0274747be27569874eef0b339da3ed5f00150e9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: