Closed
Bug 1050052
Opened 10 years ago
Closed 10 years ago
Change Lockscreen & Homescreen background underlay darkness
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S2 (15aug)
People
(Reporter: mnjul, Assigned: mnjul)
Details
(Whiteboard: [p=1])
Attachments
(3 files)
204.92 KB,
image/png
|
Details | |
252.17 KB,
image/png
|
padamczyk
:
ui-review-
|
Details |
46 bytes,
text/x-github-pull-request
|
gweng
:
review+
padamczyk
:
ui-review+
|
Details | Review |
After bug 1039631 lands the lockscreen is shaded with a uniform dark overlay. As bug 1039631 states that gradients should be abolished, let's remove the shaded overlay altogether, giving it the original unshaded look. Related: bug 950884 and bug 1020115.
Assignee | ||
Comment 1•10 years ago
|
||
This is the current look.
Assignee | ||
Comment 2•10 years ago
|
||
This is the original look without the linear gradient on the top.
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8468995 [details]
unshaded (should-be).png
Hi Patryk,
Could you tell me if this "unshaded" version is what we should be having? Thanks.
Attachment #8468995 -
Flags: ui-review?(padamczyk)
Updated•10 years ago
|
Attachment #8468995 -
Flags: ui-review?(padamczyk) → ui-review-
Comment 4•10 years ago
|
||
We need a darker underlay so the time text doesn't disappear can you make sure both the home and lockscreen have a 5% black underlay.
Comment 5•10 years ago
|
||
Sorry typo... > can you make sure both the home and lockscreen have an 8% black underlay.
Assignee | ||
Updated•10 years ago
|
Summary: Lockscreen looks significantly darker than it should be → Change Lockscreen & Homescreen background underlay darkness
Assignee | ||
Comment 6•10 years ago
|
||
Okies, 8% dark shade for lockscreen & homescreen. Does this patch look good? Thanks.
Attachment #8469856 -
Flags: ui-review?(padamczyk)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jlu
Whiteboard: [p=1]
Comment 7•10 years ago
|
||
Hey John, 8% looks good on the homescreen, its a bit too light on some of the wallpapers. Can we make it 10%? Thanks.
Assignee | ||
Comment 8•10 years ago
|
||
Hi Patryck, please see if 10% looks good on the device by checking out attachment 8469856 [details] [review] again. Thanks!
Assignee | ||
Comment 9•10 years ago
|
||
^NI Patryk (and sorry for typo on your name)
Flags: needinfo?(padamczyk)
Updated•10 years ago
|
Attachment #8469856 -
Flags: ui-review?(padamczyk) → ui-review-
Updated•10 years ago
|
Attachment #8469856 -
Flags: ui-review- → ui-review+
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8469856 [details] [review] Patch (PR @ GitHub) Hi Greg, Please help review this one-liner CSS patch. Thanks!
Attachment #8469856 -
Flags: review?(gweng)
Updated•10 years ago
|
Attachment #8469856 -
Flags: review?(gweng) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/a0274747be27569874eef0b339da3ed5f00150e9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•