1050064 - WMFMediaDataDecoder completely fails on HE-AAC streams

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

STR:
1. Pref on MP4Reader on Windows.
2. Open http://www-tvline-com.vimg.net/streaming/tvline/MAA101-Medianet.mp4 in video document.
3. observe video plays but no audio.

The audio stream is HE-AAC. We can kind of play this with the WMFReader (bug 875644) but we completely fail in the MP4Reader.

The higher level fix in the MP4Reader will be done in bug 1047180, but the WMF MediaDataDecoder needs to work for the fix in bug 1047180 to work on Windows.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Reconfigure output type of AAC decoder on stream change. This means the decoder starts giving us more data after it detects HE-AAC SBS/PS. We're still getting twice as many samples as the AudioStream expects, we'll fix that in Bug 1047180.

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 8469003 [details] [diff] [review]
Patch

Review of attachment 8469003 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay !

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/060e0b2acfbd

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/060e0b2acfbd