1050120 - [keyboard] js-kanji IME hangs after loading dictionary file.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Yuan Xulei [:yxl] (Leave from May 18)]

Steps to reproduce:

1. Refer to "apps/keyboard/js/imes/jskanji/README" to cook the "dict.json."
2. Use GAIA_KEYBOARD to enable "jp-kanji" when you reset gaia. 
   e.g. `GAIA_KEYBOARD_LAYOUTS=en,jp-kanji make reset-gaia`
3. Enable Japanese-Kanji keyboard from settings page and touch any input field to show the Japanese keyboard.
4. Tap the "あ" key on the keyboard

Expected:
The keyboard responses to the input and show candidates for "あ".

Actual:
No candidate is available.

Comment 1

[[e-mail]]

Attachment: pull request 22618

Hi rudy,
   It's just a small logic problem, thanks for your review.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8469101 [details] [review]
pull request 22618

Yuan, wdeng,
Thanks for the quick fix!  r=me.

--
For the record, it seems jp-kanji was broken because we remove the call of engine.empty() in the original renderKeyboard() after we refactored the keyboard architecture.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/80c88f1ef3237e735f204d7db24aac59ff89ebab