1050293 - Start multiple browser instances on different ports

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andrei Oprea [mention me on [e-mail]]]

By default Marionette starts up on port 2828, I would expect that by calling the constructor with a different port and bin arguments it would start up a new Marionette instance on that port. Instead it tries binding to 2828 port and fails.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Implementing this will allow Loop to better simulate an end-to-end call because we'll calling from one browser to another, rather than having a browser call itself, which is something that never happens in the wild.

Comment 2

[Julien Pagès (:parkouss)]

Hi,

I think I found a workaround for local marionette instances, but I'm not sure it is the way it must be fixed.

If you add a line here:

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/geckoinstance.py#46

like this one:

profile_args['preferences']["marionette.defaultPrefs.port"] = self.marionette_port

Then you are able to start firefox with the good port for marionette - and so start multiple marionette instance with different ports.

I don't send a patch as I'm not sure that overriding the "marionette.defaultPrefs.port" profile args value is a good idea. I write what I found in case it can helps someone. Well if it is the way to go, I can send a patch. :)

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Julien, thanks for finding this; I missed it in my bug mail!

David, would you be comfortable landing a patch that takes this approach, or would you prefer something else?

Comment 4

[David Burns :automatedtester]

Julien's approach sounds good to me. This is the approach that I have used in the past to make Selenium run in parallel.

Comment 5

[Julien Pagès (:parkouss)]

This has actually already been fixed (there is exactly the line suggested in comment 2). :)

hg log -r 216642
changeset:   216642:76feeccb28cf
user:        Ted Mielczarek <[e-mail]>
date:        Thu Nov 20 08:34:37 2014 -0500
summary:     Bug 1101539 - Make Marionette's GeckoInstance actually support passing a nonstandard port. r=jgriffin

Comment 6

[David Burns :automatedtester]

detailed in comment 5