1050356 - Make search widget indentation consistent with FirefoxSearch repo

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[:Margaret Leibovic]

Attachment: Make search widget indentation consistent with FirefoxSearch repo

Looks like the m-c patch that landed for bug 1046419 was different from the git commit. This fixes the issue with another patch for m-c, but we could also make a fixup commit to the git repo if you think what's in m-c is better.

We need to do something to fix this, though, since it breaks generating patches from the FirefoxSearch repo.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 8469364 [details] [diff] [review]
Make search widget indentation consistent with FirefoxSearch repo

Review of attachment 8469364 [details] [diff] [review]:
-----------------------------------------------------------------

Heh. Sorry about that.

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/61b29b65287f

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

I think the remaining problems are mostly due to fonts. We have to do some weird things here so that the gray background doesn't overlap the orange (hence why these rows were offset before).

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8470279 [details] [diff] [review]
Patch

Wrong bug :(

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/61b29b65287f