Closed Bug 1050391 Opened 10 years ago Closed 10 years ago

Make e10s test add-ons work without the autostart pref

Categories

(Add-on SDK Graveyard :: General, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
zombie
: review+
Details | Review
We need to test these in a running build in the new test harness
Attached file patch
Attachment #8469418 - Flags: review?(tomica+amo)
the code looks ok (didn't yet do the full review), but i'm a bit worried, because i ran this, and warnings from the content process are not visible in the console when running e10s tests in this mode, while they are visible when a firefox is started with autostart pref set..

i don't want to block your mochitestification work on this, as having our tests visible on CI, even in this mode is better than not, so i'm not sure what's the best solution here.. :\
Comment on attachment 8469418 [details] [review]
patch

r+

please disregard the above comment, looks like i messed up applying that pastebin diff..
Attachment #8469418 - Flags: review?(tomica+amo) → review+
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c22d8c0a0788cfb26ffd574f1165667c344beecb
Merge pull request #1575 from Mossop/bug1050391

Bug 1050391: Open a new e10s window before each test. r=zombie
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: