Closed Bug 1050449 Opened 6 years ago Closed 6 years ago

Autocomplete icon image-rendering property should be moved from OS X theme to content/autocomplete.css

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set
normal
Points:
2

Tracking

()

VERIFIED FIXED
mozilla34
Iteration:
34.3

People

(Reporter: rittme, Assigned: rittme)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

This is a follow up of bug 1041845. 
The image-rendering: -moz-crisp-edges is applied to autocomplete icons in a media query for 2dppx, but it should be true for no matter which resolution that needs image resizing. 

It's also at a OSX theme style-sheet, and we consider it should be moved to a content style-sheet, since it's related to more general content rendering.

http://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/autocomplete.css#118
Flags: firefox-backlog?
I double-checked with Gavin about Bernardo taking this follow-up.
Assignee: nobody → bernardo
Status: NEW → ASSIGNED
Iteration: --- → 34.2
Points: --- → 2
QA Whiteboard: [qa+]
Flags: firefox-backlog? → firefox-backlog+
Hardware: x86 → All
Added to Iteration 34.2
Summary: Autocomplete icon image-rendering property should be moved out of 2dppx "retina only" media query → Autocomplete icon image-rendering property should be moved from OS X theme to content/autocomplete.css
I made some changes to the patch to follow the decisions made on bug 1041845.
The crisp edges rendering should only apply to exactly 2dppx resolution.
Attachment #8470338 - Attachment is obsolete: true
Attachment #8470338 - Flags: review?(MattN+bmo)
Attachment #8470372 - Flags: review?(MattN+bmo)
List of icons that need testing, from https://bugzilla.mozilla.org/show_bug.cgi?id=1041845#c10,


.All tabs dropdown
.Applications pane list
.Awesomebar dropdown
.Back/forward navigation popup menu
.Bookmark toolbar (moved from theme to content)
.Panel menu bookmarks/history subviews
.Places windows (history/bookmarks)
.Preferences Home Page “Use bookmark…"
.Search engine icons (moved from theme to content)
.Sidebars (bookmark/history)
.Social API chatbox
.Social API sidebar
.Social API toolbar button
.Tabs (moved from theme to content)
.Tabs groups
QA Contact: andrei.vaida
Comment on attachment 8470372 [details] [diff] [review]
rev 2 - Autocomplete image-rendering property moved from OSX theme to content/autocomplete.css

Review of attachment 8470372 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/autocomplete.css
@@ +4,5 @@
> +
> +@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
> +@namespace html url("http://www.w3.org/1999/xhtml");
> +
> +/* Crisp rendering should only be applied to exactly 2dppx resolution */

Can you make the same comment change as bug 1041845?
Attachment #8470372 - Flags: review?(MattN+bmo) → review+
Keywords: checkin-needed
No longer depends on: 616258
https://hg.mozilla.org/mozilla-central/rev/5bd8ca0d6d6c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla34
Juan, can you take this one too for verifying on a retina screen?
Flags: needinfo?(jbecerra)
QA Contact: andrei.vaida → jbecerra
Iteration: 34.2 → 34.3
QA Whiteboard: [qa+]
Flags: qe-verify+
I have been trying to spot the difference between Aurora and Nightly (latest) on a 13" Retina display, comparing the items listed in the "all tabs" dropdown - and comparing zoomed in images, but I can't tell the difference. I also looked at the icons from the awesomebar drop-down, and tab groups.

I tried looking for differences in the images shown in the attachments in bug 1041845, but I'm sure I am missing something.
Flags: needinfo?(jbecerra)
I've verified icons from comment 5 on a Macbook 15" Retina (OS X 10.9.5) using Firefox 34 Beta 11 (BuildID=20141120192249). I've verified -moz-crisp-edges is applied to the icons, and compared them to icons in Firefox 32.0.3.

The results were mixed:
1. Icons that are blurry in 32 but show fine in 34:
.Applications pane list
.Back/forward navigation popup menu
.Places windows (history/bookmarks)
.Preferences Home Page “Use bookmark…"
.Sidebars (bookmark/history)
.Tabs groups
2. Icons that show fine in both 32 and 34:
.All tabs dropdown
.Awesomebar dropdown
.Bookmark toolbar (moved from theme to content)
.Panel menu bookmarks/history subviews
.Social API chatbox
.Social API sidebar
.Social API toolbar button
.Tabs (moved from theme to content)
3. Icons that show blurry in 34 Beta 11:
a) Menu Bar -> History
b) Preferences -> Search

Bernardo, can you check 3a) and 3b)? I think these are incorrect. Please, let me know what you think.
Flags: needinfo?(bernardo)
(In reply to Florin Mezei, QA (:FlorinMezei) from comment #12)
> 3. Icons that show blurry in 34 Beta 11:
> a) Menu Bar -> History
> b) Preferences -> Search
> 
> Bernardo, can you check 3a) and 3b)? I think these are incorrect. Please,
> let me know what you think.

Bernardo seems to not be available so I've filed bug 1105667 for the two places where blurry icons still show. Given that there were just 2 remaining places and issue is not visible unless zoomed in, I'm closing this bug, and follow up will be done on bug 1105667.
Status: RESOLVED → VERIFIED
Flags: needinfo?(bernardo)
You need to log in before you can comment on or make changes to this bug.