Closed Bug 1050521 Opened 10 years ago Closed 5 years ago

Make GMPService init async

Categories

(Core :: Audio/Video: GMP, defect, P3)

Product:
Core
Component:
Audio/Video: GMP
Version:
29 Branch
Platform:
x86_64
All
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: cpearce, Unassigned)

References

(Blocks 2 open bugs)

Details

Bug 991037 comment #39:

--- Comment #39 from Byron Campen [:bwc] <docfaraday@gmail.com> 2014-08-06 13:36:11 PDT ---
(In reply to Martin Thomson [:mt] from comment #38)
> @@ +492,5 @@
> > +    return false;
> > +  }
> > +
> > +  // presumes that all GMP dir scans have been queued for the GMPThread
> > +  thread->Dispatch(WrapRunnableNM(&GMPReady), NS_DISPATCH_NORMAL);
> 
> I think that the idea of relying on the side-effects of do_GetService above
> makes me very nervous.  What if the init of GMP requires a dispatch to
> another thread to complete?
> 
> Can't you modify the API of the GMP service to provide a notification when
> it is done?  That's more work, but seems less fragile.
>
This bug is necessary for basic playback of EME video on Windows.
Blocks: eme-m1
No longer blocks: eme-m1
Component: Audio/Video → Audio/Video: MSG/cubeb/GMP
Component: Audio/Video: MediaStreamGraph → Audio/Video: GMP
Is this still relevant?
Rank: 25
Flags: needinfo?(cpearce)
Priority: -- → P2
We can probably get away with WONTFIXing this for now, and reopen/refile if we need to. What we have now is working OK.
Flags: needinfo?(cpearce)
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.