105063 - remove mContentID field from nsXULElement

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Chris Waterson]

I don't think there is any reason for XUL elements to support the stateful frame
stuff that (I think is what) the [Get|Set]ContentID() APIs are for. As far as I
can tell, this is a write-only field.

Comment 1

[Chris Waterson]

Attachment: remove mContentID field from nsXULElement

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 53755 [details] [diff] [review]
remove mContentID field from nsXULElement

Yes! Die mContentID, die! sr=jst

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 53755 [details] [diff] [review]
remove mContentID field from nsXULElement

Stub methods, whee.  r=[e-mail]

/be

Comment 4

[David Hyatt]

Accessibility uses these to provide a unique ID for their content elements.  You
will break them with your change.  While I think that's ok, and that they can
generate their own IDs perhaps, you should probably give aaronl a headsup first.

Comment 5

[Johnny Stenback (:jst)]

From my discussions with Aron Leventhal yesterday accessibility will *not* use
the content id, they will use the nsIContent pointer value for identifying elements.

Comment 6

[Chris Waterson]

Hey aaronl, whatdya think?

Comment 7

[Aaron Leventhal]

This is okay with accessibility -we're going to use the nsIDOMNode pointer as a
32 bit unique value now.

However, bryner said he might use this for saving/restoring state.

Comment 8

[Chris Waterson]

Okay, fix checked in. Holler if something breaks.

Comment 9

[Brian Ryner (not reading)]

well, when we implement saving focus in session history, this won't work for
xul... i assume that's ok.