Closed Bug 1050652 Opened 6 years ago Closed 6 years ago

Implement GetEvictionOffset for WebM reader.

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
Attachment #8469826 - Flags: review?(cajbir.bugzilla)
Blocks: MSE
Depends on: 1049133
Fix a silly compile error. :-|
Attachment #8469826 - Attachment is obsolete: true
Attachment #8469826 - Flags: review?(cajbir.bugzilla)
Attachment #8469861 - Flags: review?(cajbir.bugzilla)
Comment on attachment 8469861 [details] [diff] [review]
Implement GetEvictionOffset for WebM reader. v2

Review of attachment 8469861 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webm/WebMBufferedParser.h
@@ +199,5 @@
>  
>    void NotifyDataArrived(const char* aBuffer, uint32_t aLength, int64_t aOffset);
>    bool CalculateBufferedForRange(int64_t aStartOffset, int64_t aEndOffset,
>                                   uint64_t* aStartTime, uint64_t* aEndTime);
> +  bool GetOffsetForTime(uint64_t aTime, int64_t* aOffset, bool aSyncPoint);

Remove the boolean parameter and make it an enum of some sort. Add a comment explaining what it is.
Attachment #8469861 - Flags: review?(cajbir.bugzilla) → review+
Address review comments, carry forward r+
Attachment #8469861 - Attachment is obsolete: true
Attachment #8470576 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/1150a58d8b3a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
This patch breaks seeking on the youtube demo page.  If I revert this patch then seeking works again. I've raised bug 1054970 for this.
Attached image yt seekbar
Is this caused by this bug?
Ugh. Meant to post it in Bug 1054970.
Depends on: 1054970
You need to log in before you can comment on or make changes to this bug.